Page MenuHomePhabricator

Visibility of wrong datanode is toggled in PointbasedRegistration Plugin
Closed, ResolvedPublic

Description

steps to reproduce:

  • load two images
  • open PointbasedRegistration Plugin
  • select "Toggle point editing" button of first image
  • add four points to first image with shift + left click
  • unselect "Toggle point editing" button of first image
  • select "Toggle point editing" button of second image
  • toggle visibility of first datanode

-> all datanodes are invisible. Visibility of pointsets must be visible to add new points. So the user has to select and toggle the visibility of the pointset and image manually.

Event Timeline

Bug appears just the first time toggling the visibility of the other node.
After select and toggle the visibility of the pointset and image manually it works correct.

QmitkPointBasedRegistrationView.cpp #1346
the comment of this line says "hide all images" -> why hiding all images?!

deleting this line solves the problem ... but maybe there could be some side effects

Another visibility problem:
Step1:

  • load 2 images
  • select datanode1 frist and then the other (datanode2)
  • deselect all
  • do the same again

-> visibility of all datanodes is toggled

Step2:
-select datanode2 first and then datanode1
-deselect all
-do the same again
-> visibility of all datanodes is toggled, you can start from step1 again

Another visibility problem:

  • load 2 images
  • select both
  • click "toggle point editing"-button of fixed data
  • expand fixed datanode in data manager

->the visibility of all datanodes is set to false

QmitkPointBasedRegistrationView.cpp

The function SetImagesVisible(selection) is responsible for the strange behavior for the bugs above.

see no sense of "SetImagesVisible(selection)" -> deleted the method

after deleting everything works like expected

User riecker has pushed new remote branch:

bug-18492-VisibilityBehaviorBug

User riecker has pushed new remote branch:

bug-18492-VisibilityBehaviorBug-integration

[cb32e6]: Merge branch 'bug-18492-VisibilityBehaviorBug-integration'

Merged commits:

2015-01-07 13:32:59 Nico Riecker [bd9f69]
Merge branch 'bug-18492-VisibilityBehaviorBug' into bug-18492-VisibilityBehaviorBug-integration


2014-12-03 16:29:46 Nico Riecker [25e499]
deleted the method which is responsible for the wrong visibility behavior