Page MenuHomePhabricator
Create Task
Maniphest T18556

Add CopyDeep method to PlanarFigure
Closed, ResolvedPublic
Actions

Description

The class mitk::PlanarFigure has not method to create a copy of an instance.

Thus, a CopyDeep method should be added.

Related Objects

Event Timeline

engelm added projects: MITK, Bugzilla.Dec 17 2014, 4:19 PM
• git-user added a subscriber: • git-user.Dec 17 2014, 4:26 PM

User engelm has pushed new remote branch:

bug-18556-add-copydeep-for-planarFigure
engelm added a subscriber: engelm.Dec 17 2014, 4:46 PM

[ecfb75]: Merge branch 'bug-18556-add-copydeep-for-planarFigure'

Merged commits:

2014-12-17 16:19:00 Markus Engel [1b4ace]
added copyDeep for PlanarFigures

engelm added a comment.Dec 17 2014, 4:47 PM

New method PlanarFigure::DeepCopy() has been implemented.

kislinsk added a subscriber: kislinsk.Dec 17 2014, 5:10 PM

Marcus, this method was declared deprectaed and was just recently removed (for good reason ;-)). Use the Clone method instead and revert your changes please.

engelm added a comment.Dec 19 2014, 2:14 PM

[786c26]: Merge branch 'bug-18556-add-copydeep-for-planarFigure'

Merged commits:

2014-12-18 13:36:56 Markus Engel [71535c]
extended unittest for PlanarArrow with cloning

2014-12-18 13:35:04 Markus Engel [6b4839]
Revert "added copyDeep for PlanarFigures"

This reverts commit 1b4aceab0b0b94eb29131afc9210369e780ae272.

engelm added a comment.Dec 19 2014, 2:18 PM

Oops, that explains why I wasn't able to find the method.

I reverted the changes and added a test for the Clone() method to the PlanarArrowTest..

kislinsk added a comment.Dec 19 2014, 2:33 PM

Sorry, Dashboard is red because of your changes. Reopened bug.

engelm added a comment.Dec 19 2014, 2:36 PM

[64f5c6]: COMP: Merge branch 'bug-18556-add-copydeep-for-planarFigure'

Merged commits:

2014-12-19 14:28:42 Markus Engel [814a0f]
fixed warnings treated as error

engelm added a comment.Dec 19 2014, 2:52 PM

[48342d]: COMP: Merge branch 'bug-18556-add-copydeep-for-planarFigure'

Merged commits:

2014-12-19 14:44:23 Markus Engel [60e769]
fixed another warning

engelm added a comment.Dec 19 2014, 3:23 PM

Looking good now =)

kislinsk edited projects, added MITK (2015-03); removed MITK.Aug 1 2016, 10:49 PM
MITK · MIC · IMSY · DKFZ