Page MenuHomePhabricator

QmitkDataStorageComboBoxWithSelectNone can not handle renamed nodes
Closed, ResolvedPublic

Description

after renaming a node both nodes ar still visible in the combo box and none of them is working anymore.

Event Timeline

Renaming a node overwrites the '--' symbol (ZERO_ENTRY_STRING). The modified event correctly recognized

  • QmitkDataStorageComboBox::OnDataNodeDeleteOrModified
  • QmitkDataStorageComboBox::SetNode with same node at both arguments
  • QmitkDataStorageComboBoxWithSelectNone::SetNode( index, node )

which then calls the QmitkDataStorageComboBox::InsertNode( index - 1, node ) without further checking.

User hering has pushed new remote branch:

bug-18649-RenamingNodes-ComboBoxWithSelectNone

[24826b]: Merge branch 'bug-18649-RenamingNodes-ComboBoxWithSelectNone'

Merged commits:

2015-03-04 16:51:13 Jan Hering [75b76e]
Add checks for node renaming

  • in case of renaming, the QComboBox item texts are adapted directly with the correct index

    otherwise the SetNode( idx, nodex) is forwarded to the StorageBox::InsertNode( idx-1, node) (the old behavior)