Page MenuHomePhabricator

Remove LegacyIO dependency from PlanarFigure module
Closed, ResolvedPublic

Event Timeline

User kolbch has pushed new remote branch:


On my branch the following tests still fail:

	  8 - mitkPackageTest (Failed)

116 - mitkSurfaceVtkMapper2DTest (Failed)
326 - mitkManualSegmentationToSurfaceFilterTest_US4DCyl.nrrd (Failed)
330 - mitkManualSegmentationToSurfaceFilterTest_Pic2DplusT.nrrd (Failed)
334 - mitkManualSegmentationToSurfaceFilterTest_Png2D-bw.png (Failed)
360 - mitkTrackingVolumeGeneratorTest (Failed)
370 - mitkNavigationToolReaderAndWriterTest (Failed)

I changed the mitkManualSegmentationToSurfaceFilterTest, mitkTrackingVolumeGenerator and mitkNavigationToolReaderAndWriter. So these test fails should be directly related to my changes.

mitkTrackingVolumeGeneratorTest fails because the file reader does not yet work with input streams.
the current problem in mitkTrackingVolumeGenerator is that the temporary file, created from the resource stream is missing the .stl ending.
let's wait until the "load from stream" feature works, before we create a hacked solution.

I would like to merge this bug asap due to lots of potential for conflicts. Unfortunately, we modified the core (only mitkIOUtil).

Sascha and Christoph added a small method for loading data in the commit:

Christoph, could you please write a short core change request?

We added a convenience method to the mitk::IOUtils which allows to load a basedata object from a us::ResourceStream.
the original resource path is used to acquire the correct mimetype and uses the according reader to create the mitk::BaseData object

[b6d54e]: Merge branch 'bug-18651-RemoveLegacyIO'

Merged commits:

2015-01-29 13:12:45 Thomas Kilgus [4c2eb7]
Converted ManualSegmentationToSurfaceFilterTest to CPPUNIT and added reference data for the filter.

2015-01-28 15:19:10 Christoph Kolb [f8a1c3]
remove legacyIO methods

2015-01-28 15:17:57 Christoph Kolb [8eb3f0]
add a convenience function to load streams in IOUtil

2015-01-21 18:08:59 Christoph Kolb [56672a]
remove legacyIO in diffusionimaging

2015-01-21 18:08:43 Christoph Kolb [451866]
remove legacy in examples

2015-01-21 18:08:29 Christoph Kolb [23f6bc]
Merge branch 'bug-18651-RemoveLegacyIO' of into bug-18651-RemoveLegacyIO


2015-01-21 16:21:23 Christoph Kolb [274b2e]

2015-01-21 16:17:59 Thomas Kilgus [a70957]
Merge branch 'bug-18651-IGTUIandPlugins' into bug-18651-RemoveLegacyIO

2015-01-21 16:15:41 Thomas Kilgus [30ea95]
Fixed: IGTUI, US, DatamangerView, qt.ext and tofutil.

2015-01-21 15:52:06 Christoph Kolb [908ab7]
Merge branch 'bug-18651-RemoveLegacyIO' of into bug-18651-RemoveLegacyIO

2015-01-21 15:51:06 Christoph Kolb [1433cc]
remove legacyIO from diffusionImagingminiapps

2015-01-21 15:41:11 Thomas Kilgus [6e5817]
Merge branch 'bug-18651-WIPthomas' into bug-18651-RemoveLegacyIO

2015-01-21 15:39:27 Thomas Kilgus [21d328]
Removing dependency to LegacyIO. WIP.

2015-01-21 15:23:17 Christoph Kolb [947c65]
diffusionimaging. PlanarFigure and QtWidgets

2015-01-21 15:05:03 Thomas Kilgus [3200e1]
Removed MitkLegacyIO dependency from PlanarFigure, PlanarFigureSegmentation and ImageStatistics.

2015-01-21 15:04:06 Thomas Kilgus [7042f7]
Removed MitkLegacyIO dependency from IpPic.

[1fc088]: Merge branch 'bug-18651-RemoveOldIOHeaders'

Merged commits:

2015-01-30 13:25:27 Christoph Kolb [57fad0]
COMP: remove includes from LegacyIO

[9ab230]: Merge branch 'bug-18651-FixUSImageLoggingFilter'

Merged commits:

2015-01-30 15:31:19 Christoph Kolb [a17d93]
COMP: remove deprecated macro and reimplement SetImageFilesExtension

[aa2299]: Merge branch 'bug-18651-fix-wrong-qt-webkit-define-handling'

Merged commits:

2015-02-11 19:26:42 Sascha Zelzer [2b03c2]
COMP: Removed Qt Webkit defines.

User zelzer has pushed new remote branch: