Page MenuHomePhabricator
Create Task
Maniphest T18853

Wrong description of getBounds in BaseGeometry
Closed, ResolvedPublic
Actions

Description

Documentation shows description of "GetTimeBounds" for the method "GetBounds". This is wrong. GetTimeBounds does not exist anymore.

Solution:
Delete the following comment in BaseGeometry.h

//##Documentation
//## @brief Get the time bounds (in ms)
//itkGetConstReferenceMacro(TimeBounds, TimeBounds);

...and... have a look into the #ifdef DOXYGEN_SKIP. Is it necessary? What does it do?

Event Timeline

• wildes added projects: MITK, Bugzilla.Mar 16 2015, 11:37 AM
• git-user added a subscriber: • git-user.Apr 17 2015, 2:39 PM

User goch has pushed new remote branch:

bug-18853-delete-commented-out-code
• goch added a subscriber: • goch.Apr 17 2015, 2:41 PM

Core change request flag:
I only deleted commented out lines of code

• goch added a comment.Apr 17 2015, 2:52 PM

Regarding the "DOXYGEN_SKIP"

That seems to be a misuse of the macro, as the code is not compiled.

After the release I would suggest checking all instances of DOXYGEN_SKIP and deleting them if applicable. I would not do this now however, as that might result in changed behaviour.

kislinsk edited projects, added MITK (2015-03); removed MITK.Aug 1 2016, 10:49 PM
MITK · MIC · IMSY · DKFZ