If delete is pressed in the local storage tab of the dicom browser, everything is deleted regardless of the selection.
Description
Event Timeline
I refactored the OnDeleteButtonClicked method into three cascading method calls DeletePatients, DeleteStudies, and DeleteSeries. The first method gathers information on selected patients (how many studies and series they contain) and asks the user if he or she really want to delete all these items. If no patient is selected, the method returns false and in that case the next method in the cascade is called which does the same on the study level, and so on...
We should still address the issue that is not intuitive to only select series or studies without implicitly selected their parents, e.g., the use might think he or she just selected a series but also the according study and patient are selected. It is hard to see that on Windows as selected but inactive table rows are gray instead of blue.
We might consider to only take selected *and* active items into account. However, this might not be intuitive on Mac OS, as there also the inactive selections are blue and hence it is hard to see which selection is actually active.
[b2b2f8]: Merge branch 'bug-18992-DICOMLocalStorageDelete'
Merged commits:
2015-04-16 22:00:58 Andreas Fetzer [8bc130]
Fixed wrong QMessageBox return type check
2015-04-16 15:32:17 Stefan Kislinskiy [490832]
Inform user on which resp. how many items are about to be deleted.
[b9a892]: Merge branch 'bug-18992-Qt4Qt5Fix'
Merged commits:
2015-04-16 22:42:28 Stefan Kislinskiy [de68e7]
Explicitly specify Yes and No buttons in Delete message boxes.