Especially override and things that can be semi-automatically updated by clang-modernize. Let's see how far this can get before the release. Would be nice if we could get it in since fixing this after release would probably cause many more merge troubles over the time for people.
Description
Description
Related Objects
Related Objects
- Duplicates Merged Here
- T19058: Return of nullptr in OptitrackTrackingDevice
Event Timeline
Comment Actions
As discussed we will include this in the release. First commit/merge is only for Modules/
Comment Actions
[2f7cd4]: Merge branch 'bug-19035-cpp11-modernizations'
Merged commits:
2015-05-02 15:52:51 Marco Nolden [7bc50d]
Override in JsonCpp
2015-05-02 15:52:26 Marco Nolden [5ea011]
Added C++11 modernizations to CppMicroServices
2015-05-05 13:31:25 Marco Nolden [c697a5]
C++11 modernizations
- Correct use of override
- nullptr
- some range-based loops (clang-modernize -risk=safe)
Comment Actions
[05b926]: Merge branch 'bug-19035-cpp11-modernizations'
Merged commits:
2015-05-05 15:59:57 Marco Nolden [712f75]
COMP: some overrides don't apply to Qt4
Comment Actions
[7b2291]: Merge branch 'bug-19035-cpp11-modernizations'
Merged commits:
2015-05-05 17:21:46 Marco Nolden [df9e62]
Removed some strange method hiding
2015-05-05 17:22:03 Marco Nolden [09b72d]
More overrides
2015-05-05 15:59:57 Marco Nolden [7e94f9]
COMP: some overrides don't apply to Qt4
Comment Actions
The CppMicroServices changes (override) would imply a minimum compiler version bump for the external project when pushed upstream. I am not too eager to make C++11 a hard requirement yet...
Could we either use macros or disable the Clang warning for the CppMicroServices code somehow (I think the clang warning/error was one of the reasons for the changes)?
Comment Actions
[56fbb6]: Merge branch 'bug-19035-cpp11-modernizations'
Merged commits:
2015-05-06 17:16:34 Marco Nolden [f94ac0]
COMP: fixed crashing tests
Cleaned up OperationActor (multiple) inheritances
Comment Actions
[bef085]: Merge branch 'bug-19035-cpp11-modernizations-2'
Merged commits:
2015-05-11 17:51:01 Marco Nolden [c02d03]
More c++ modernizations
- clang-modernizing the plugins
- auto and nullptr in modules as well
- trailing whitespace cleanup
Comment Actions
[27fffd]: Merge branch 'bug-19035-cpp11-modernizations-2'
Merged commits:
2015-05-11 21:32:22 Marco Nolden [5da6f4]
COMP: fix platform specific nullptr return