Page MenuHomePhabricator

C++11 and OpenCL
Closed, ResolvedPublic

Description

Build OpenCL with our recent changes for C++11. Matt reported a bug on the mailing list:

In file included from /Users/mattclarkson/build/MITK/Modules/OpenCL/./mitkOclImage.h:29:
/Users/mattclarkson/build/MITK/Modules/OpenCL/./mitkOclImageFormats.h:107:10: warning: 'mitk::OclImageFormats::PrintSelf' hides overloaded virtual function

  [-Woverloaded-virtual]
void PrintSelf();
     ^

/Users/mattclarkson/build/MITK-SuperBuild-Debug/ep/include/ITK-4.7/itkLightObject.h:127:16: note: hidden overloaded virtual function

    'itk::LightObject::PrintSelf' declared here: different number of parameters (2 vs 0)
virtual void PrintSelf(std::ostream & os, Indent indent) const;
             ^

In file included from /Users/mattclarkson/build/MITK/Modules/OpenCL/mitkOclBinaryThresholdImageFilter.cpp:17:
In file included from /Users/mattclarkson/build/MITK/Modules/OpenCL/./mitkOclBinaryThresholdImageFilter.h:20:
In file included from /Users/mattclarkson/build/MITK/Modules/OpenCL/./mitkOclImageToImageFilter.h:20:
In file included from /Users/mattclarkson/build/MITK/Modules/OpenCL/./mitkOclImageFilter.h:21:
/Users/mattclarkson/build/MITK/Modules/OpenCL/./mitkOclImage.h:96:8: warning: 'mitk::OclImage::Modified' hides overloaded virtual function

    [-Woverloaded-virtual]
void Modified(int _type);
     ^

/Users/mattclarkson/build/MITK-SuperBuild-Debug/ep/include/ITK-4.7/itkObject.h:99:16: note: hidden overloaded virtual function 'itk::Object::Modified'

    declared here: different number of parameters (0 vs 1)
virtual void Modified() const;
             ^

In file included from /Users/mattclarkson/build/MITK/Modules/OpenCL/mitkOclBinaryThresholdImageFilter.cpp:17:
/Users/mattclarkson/build/MITK/Modules/OpenCL/./mitkOclBinaryThresholdImageFilter.h:39:3: error: 'GetClassHierarchy' marked 'override' but does not override

    any member functions
mitkClassMacro(OclBinaryThresholdImageFilter, OclImageToImageFilter);
^

/Users/mattclarkson/build/MITK/Modules/Core/include/mitkCommon.h:50:36: note: expanded from macro 'mitkClassMacro'

virtual std::vector<std::string> GetClassHierarchy() const override { return mitk::GetClassHierarchy<Self>(); } \
                                 ^

2 warnings and 1 error generated.

Event Timeline

[909511]: Merge branch 'bug-19085-FixOpenCL'

Merged commits:

2015-05-20 13:28:59 Thomas Kilgus [245a8f]
Use correct macro for OclBinaryThresholdImageFilter.