Page MenuHomePhabricator
Create Task
Maniphest T19271

Switching the icon theme on an installed MITK does not do anything
Closed, ResolvedPublic
Actions

Description

Compare these two workflows:

  1. Build MITK yourself
  2. Run Workbench
  3. Open Preferences->Themes
  4. Switch icon theme to "awesome"

-> Result: MITK now uses the awesome icons

  1. Install MITK (even the same machine that build the installer)
  2. Run Workbench
  3. Open Preferences->Themes
  4. Switch icon theme to "awesome"

-> Result: Icons do not change

This worked in MITK 2014-10, I can not test it on MITK-2015-05 as the preference dialog is broken there.

It does however work on linux and mac, so I assume it was broken by (in order of estimated likelihood)

  1. Blueberry changes
  2. CTK changes
  3. The Qt5 migration

Revisions and Commits

rMITK MITK
rMITK4815936641ba Fixes T19271

Related Objects

Event Timeline

• goch added projects: MITK, Bugzilla.Aug 26 2015, 3:52 PM
zelzer added a subscriber: zelzer.Aug 26 2015, 7:15 PM

What does "broken" mean here? How did you work through steps 1. - 4. with a broken preferences dialog?

• goch added a subscriber: • goch.Aug 27 2015, 1:47 PM

"Broken" was fixed in T19097. Child preference pages were sometimes not added to the treelist. The above is the workflow after fixing that bug. It just means I can not test it on the binaries of the release directly, but I am going to assume the behaviour has not changed much from 2015.05.0 to the current state of 2015.05.2

kislinsk edited projects, added MITK (2016-03); removed MITK.Aug 1 2016, 10:49 PM
kislinsk edited projects, added MITK (2016-11); removed MITK (2016-03).Aug 26 2016, 12:47 PM
• goch moved this task from Backlog to Focus Tasks on the MITK (2016-11) board.Oct 17 2016, 1:02 PM
• goch claimed this task.Oct 17 2016, 6:43 PM

It seems the themes can just not be found in the installed version.
While the icons themselves are indeed compiled into
liborg_mitk_gui_qt_ext.dll

if I add the lines

bool doesThemeHaveOpen = QIcon::hasThemeIcon("document-open");
if (doesThemeHaveOpen)
{
  std::cout << "\n\n\n\n Theme " << QIcon::themeName().toStdString() << " has icon \n\n\n\n" << std::endl;
  std::cout << "\n\n\n\n Themesearchpaths: " << QIcon::themeSearchPaths().join(";").toStdString() << "\n\n\n\n" << std::endl;
}
else
{
  std::cout << "\n\n\n\n Theme " << QIcon::themeName().toStdString() << " does not have icon \n\n\n\n" << std::endl;
  std::cout << "\n\n\n\n Themesearchpaths: " << QIcon::themeSearchPaths().join(";").toStdString() << "\n\n\n\n" << std::endl;
}

to the QmitkExtWorkbenchWindowAdvisor, I get the first output when starting from the bin directory and the second one when starting from the _CPack_Packages.
The tange icons seem to be shown because they are the default, as the tango theme cannot be found either.

• goch added a comment.Oct 21 2016, 4:28 PM

Using QDir it is also possible to see that all required files are actually present in the qt resource system:

:/org_mitk_icons/icons/awesome/ contents: index.theme;scalable
:/org_mitk_icons/icons/awesome/scalable/actions/ contents: document-open.svg;document-print.svg;document-save.svg;edit-delete.svg;edit-redo.svg;edit-undo.svg;go-down.svg;go-home.svg;go-next.svg;go-previous.svg;go-up.svg;system-log-out.svg;view-list-details.svg;view-list-icons.svg;view-refresh.svg

• goch added a comment.EditedOct 21 2016, 5:56 PM

Potentially related bug:
https://codereview.qt-project.org/#/c/114415/
however, that one should have been fixed by now. This makes the Qt5 migration a more likely cause.

• goch added a comment.Oct 21 2016, 6:38 PM

It seems I have found the issue. We are currently not installing the icon engines, which results in the icons not being created and only the fallbacks being used, even though all the resources are there.

I can fix the issue by manually copying qsvgicon.dll to plugins/iconengines/

• goch added a comment.Oct 25 2016, 6:08 PM

Pushed new branch T19271-allow-icon-the-switching-in-installer.

• goch closed this task as Resolved by committing rMITK4815936641ba: Fixes T19271.Oct 25 2016, 6:09 PM
• goch added a commit: rMITK4815936641ba: Fixes T19271.
• goch mentioned this in rMITKccbf16b380b9: Merge branch 'T19271-allow-icon-the-switching-in-installer'.
• goch moved this task from Focus Tasks to Included on the MITK (2016-11) board.Jan 10 2017, 12:26 PM
MITK · MIC · IMSY · DKFZ