Page MenuHomePhabricator
Create Task
Maniphest T19284

Display Update with crosshair interaction (Scrolling/..) is inefficient
Closed, ResolvedPublic
Actions

Description

the slice navigation controller communicates a newly selected slice
(in SliceNavigationController::SelectSliceByPoint( const Point3D &point ))

by sending a new world geometry event

this->SendCreatedWorldGeometryUpdate();

this one replaces the old one.

This is not neccessary, because the world geometry should not have been changed.
(Instead only the plane geometries should be changed).

Related Objects

Event Timeline

• webechr added projects: MITK, Bugzilla.Aug 28 2015, 2:45 PM
kislinsk edited projects, added MITK (2016-03); removed MITK.Aug 1 2016, 10:49 PM
kislinsk edited projects, added MITK (2016-11); removed MITK (2016-03).Aug 26 2016, 12:47 PM
kislinsk edited projects, added MITK; removed MITK (2016-11).Feb 6 2017, 11:23 AM
• hettich added a subscriber: • hettich.Mar 22 2019, 5:34 PM
kalali mentioned this in T28578: [mxn multi widget] Optimization of the mxn multi widget.Jun 22 2021, 1:15 PM
kalali edited projects, added MITK (v2022.10); removed MITK.May 12 2022, 9:42 AM
kalali mentioned this in T29290: SliceNavigationController and its Stepper fire too many events.Sep 8 2022, 5:27 PM
kalali closed this task as Resolved.Nov 9 2022, 6:48 PM
kalali claimed this task.
kalali added a subscriber: kalali.

I looked into this and although I understand the problem, the issue does not really exist, as far as I can see:

  • changing the slice via scrolling will call SliceNavigationController::SelectSliceByPoint
  • calling SliceNavigationController::SelectSliceByPoint will call SliceNavigationController::SendCreatedWorldGeometryUpdate
  • calling SliceNavigationController::SendCreatedWorldGeometryUpdate will InvokeEvent(GeometryUpdateEvent(m_CreatedWorldGeometry, m_Slice->GetPos()))
  • invoking the event will lead to a call to BaseRenderer::UpdateGeometry

-> until here I agree with the task description

However, the BaseRenderer::UpdateGeometry-function simply extracts the plane geometry from the already valid member variable m_CurrentWorldGeometry; the variable is NOT newly assigned / replaced.

MITK · MIC · IMSY · DKFZ