Page MenuHomePhabricator

wrong event sent when editor closed by 'Close Project' action
Closed, InvalidPublic

Description

If you close an editor by clicking the 'x' button, a PartClosed event is signalled. However, if you click on the 'Close Project' button on the toolbar, the editor gets also closed but a PartHidden event is sent.

I would actually prefer if the editor stayed open, but if it is not possible, the right event should be signalled at least. Maybe the editor can veto the closing, I need to check.

Event Timeline

This is invalid, the actual problem was that the specification of the IPartListener functions have changed and my implementation did not override the empty implementations any more. The smart pointers are passed as constant reference now. This could be mentioned in the release notes.

kislinsk changed the task status from Invalid to Spite.Jun 27 2018, 1:29 PM
kislinsk added a project: Bulk Edit.
kislinsk changed the task status from Spite to Invalid.Jun 27 2018, 1:35 PM
kislinsk removed a project: Bulk Edit.