Page MenuHomePhabricator

ConstrainZoomingAndPanning on CameraController does not work correctly
Closed, InvalidPublic

Description

The DisplayGeometry had a feature to constrain the zooming and the panning so that these interactions were not possible if the whole image was visible.

This feature has been moved to the CameraController when the DisplayGeometry was removed. However, the feature does not work as it used to!

In my case, the image is square (512*512) but the renderwindow is wider than high.
In this case, the height is constrained so that I cannot zoom out any further although I can still pan left and right.

In the original version, I was able to zoom out so far, that panning was no longer possible because the whole image was visible. Now, the whole height is visible, but the renderwindow is not high enough to display the whole width of the image.

So, there seems to be a bug in the method mitk::CameraController::ComputeMaxParallelScale() that should be fixed.
I was not able to check if this issue also occurs in the workbench because the code has not been used in a release yet, but I strongly think it does.

Event Timeline

The new method mitk::CameraController::ComputeMaxParallelScale() was intentionally designed not to constrain the panning as long as the image is still within the bounds of the viewport.

Is this still a problem that should be discussed?

kislinsk added a subscriber: kislinsk.

Changed status to Invalid as it seems to be a It's a feature, not a bug thing. Also, wasn't discussed any further.

kislinsk changed the task status from Invalid to Spite.Jun 27 2018, 1:29 PM
kislinsk added a project: Bulk Edit.
kislinsk changed the task status from Spite to Invalid.Jun 27 2018, 1:35 PM
kislinsk removed a project: Bulk Edit.