Page MenuHomePhabricator

DICOMITKSeriesGDCMReader is still not thread safe
Closed, ResolvedPublic

Description

In ticket http://bugs.mitk.org/show_bug.cgi?id=18955 this issue was already addressed but it only fixed the concurrent access for a single instance of DICOMITKSeriesGDCMReader. If you try to load multiple images using multiple instances of DICOMITKSeriesGDCMReader, then using 'setlocale' will still cause a data race and probably crash.

The easy fix would be to make the mutex protecting this a static variable.

Event Timeline

User tweihs has pushed new remote branch:

bug-19507-static-mutex-DICOMITKSeriesGDCMReader

[9908cf]: Merge branch 'bug-19507-static-mutex-DICOMITKSeriesGDCMReader'

Merged commits:

2016-02-02 14:53:04 Tobias Weihs [33ea43]
removed FixupSpacing function declaration, it is not implemented


2016-02-02 14:52:38 Tobias Weihs [a9a3ef]
made functions const or static if possible


2016-02-02 14:51:44 Tobias Weihs [0b33ee]
removed unnecessary include, rearranged includes


2016-02-02 14:51:02 Tobias Weihs [4d6230]
made mutex locking the locales static

User engelm has pushed new remote branch:

bug-19507-improve-threadsafety-of-dicom-loading