Page MenuHomePhabricator

Comparing directory names as strings can mismatch
Closed, ResolvedPublic

Description

I got a weird error in FindDCMTK.cmake after I changed the path where to build our MITK based app. The error originates from MITKConfig.cmake.in, where there is a comparison of two directory names by STREQUAL. Although, I used lower case drive letters everywhere, CMake turns the build directory names of external projects into a canonical form, in which the drive letters are upper case, and because of this the directory names will not match.

Pull request follows.

Event Timeline

User kislinsk has pushed new remote branch:

bug-19588-ComparingDirNamesCanMismatch

[1be717]: Merge branch 'bug-19588-ComparingDirNamesCanMismatch'

Merged commits:

2016-03-11 13:48:39 Stefan Kislinskiy [92089d]
Merge remote-tracking branch 'NifTK/bug-19588-mitk-config-canonical-path' into bug-19588-ComparingDirNamesCanMismatch


2016-03-07 17:01:51 Miklos Espak [6c63be]
Get canonical directory name before comparing with STREQUAL

Signed-off-by: Miklos Espak <m.espak@ucl.ac.uk>