Page MenuHomePhabricator
Create Task
Maniphest T19812

CppMicroServices: don't add FORTIFY_SOURCE
Closed, ResolvedPublic
Actions

Description

it conflicts with system defined compiler flag and I need to add -U_FORTIFY_SOURCE all the time, please don't do it or add it with -U_FORTIFY_SOURCE prefixed

thanks!

Related Objects

Event Timeline

heather added projects: MITK, Bugzilla.Jul 1 2016, 6:02 PM
nolden added subscribers: heather, zelzer, nolden.Aug 8 2016, 4:01 PM

@heather: could you provide a few more details please?
@zelzer: is this something you fixed along the new us release?

mpkh added a subscriber: mpkh.Aug 8 2016, 7:17 PM

@nolden it's very common issue, e.g. googling "FORTIFY_SOURCE redefinition" will prove that it's common around many people
PR: https://github.com/CppMicroServices/CppMicroServices/pull/29

zelzer added a comment.Aug 8 2016, 8:17 PM

The CppMicroServices PR will be integrated into the 3.0 release. You can fix it in MITK as well if you want, we could take care of merging the changes later.

kislinsk lowered the priority of this task from Unbreak Now! to High.Aug 9 2016, 9:24 AM
kislinsk edited projects, added MITK (2016-11); removed MITK.
kislinsk claimed this task.Oct 28 2016, 1:14 PM
kislinsk added a comment.Oct 28 2016, 1:17 PM

Pushed new branch T19812-CppMicroServicesUndefineFORTIFY_SOURCE.

kislinsk mentioned this in rMITK4b41aa591027: Merge branch 'T19812-CppMicroServicesUndefineFORTIFY_SOURCE'.Oct 28 2016, 1:18 PM
kislinsk closed this task as Resolved.Oct 28 2016, 1:18 PM
MITK · MIC · IMSY · DKFZ