Page MenuHomePhabricator
Create Task
Maniphest T19820

Do not send FocusChangedEvent when focus does not change
Closed, ResolvedPublic
Actions

Description

Focus events have been dropped in 2016.03.0 and added back as part of #19697. There is a minor issue with the implementation that has been discovered by the rigorous tests for our viewer.

Could you add an extra check in RenderingManager::SetRenderWindowFocus so that the event is not sent out if the focus is already on the same window?

Revisions and Commits

Restricted Differential Revision

Related Objects

Event Timeline

espak added projects: MITK, Bugzilla.Jul 7 2016, 6:16 PM
espak added a subscriber: espak.Jul 7 2016, 6:31 PM

https://github.com/MITK/MITK/pull/134

kislinsk triaged this task as High priority.Aug 9 2016, 9:20 AM
kislinsk edited projects, added MITK (2016-11); removed MITK.
kislinsk added subscribers: • kolbch, kislinsk.

@kolbch Didn't you work on this at the MITK Users Meeting this year together with @espak? Would be nice if you could take care of the task, thank you.

espak added a comment.Aug 9 2016, 6:47 PM

Yes, Christoph added back the focus events after the meeting. This issue came up later.

• kolbch added a revision: Restricted Differential Revision.Aug 15 2016, 11:46 AM
• kolbch claimed this task.Aug 15 2016, 11:51 AM
• kolbch mentioned this in rMITK16d4704c7033: Do not send FocusChangedEvent when focus does not change.Aug 15 2016, 1:38 PM
• kolbch closed this task as Resolved.Aug 15 2016, 1:41 PM
MITK · MIC · IMSY · DKFZ