Note: the unit test for mitk::TransferFunction (mitkTransferFunctionTest) currently does not cover initialization related code. When implementing a transfer function initializer class, a unit test should be created as well (cf. T2204)

Changes of the Transfer Function class

We implemented a new class for the initialization of the transfer function. Patch is attached.

Mathias: is this as intended?

Timo: you should also enhance the unit test if necessary

Thanks for looking into this. The basic implementation looks fine, I'd only suggest to decouple the new class completely from the mitk::TransferFunction. In your implementation it is still used by TransferFunction, and TransferFunction still has a method SetMode().

A simple way to achieve this decoupling would be to implement the new class as an initializer class, which takes an existing instance of TransferFunction and initializes it with the selected transfer function (e.g. in a method InitializeTransferFunction() after setting the desired TF by SetMode(). Have a look at the ITK class CeneteredTransformInitializer which uses a similar approach:

http://www.itk.org/Doxygen314/html/classitk_1_1CenteredTransformInitializer.html

Since the initialized TFs are just an arbitrary default set of TFs, it would be nice to create a general interface for TF initialization, and a derived class for the functions that you have. The basic implementation could look like this:

class TransferFunctionInitializer
{
public:

void SetTransferFunction( TransferFunction* transferFunction );

virtual void InitializeTransferFunction() = 0;

/* etc. */

}

class DefaultTransferFunctionInitializer
{
public:

enum TransferFunctionModes
{
  // like before
}

void SetMode( int mode );

virtual void InitializeTransferFunction(); // concrete implementation

}

DefaultTransferFunctionInitializer should of course derive from TransferFunctionInitializer :)

Unsetting needs_core_modification flag until until patch is adapted to Mathias' suggestions. Please set to ? again when changes are ready.

Patch contains all classes

We created an independent class for the Transferfunction to initialize the mode and updated the Test for Transferfunction

[SVN revision 24927]
FIX (#2274): Relocated transfer function initialization into separate class and updated test

[SVN revision 24928]
COMP (#2274): Committed missing files.cmake

See commit message 24927