Page MenuHomePhabricator

Apply C++ 11 modernizations
Closed, ResolvedPublic

Description

Quite a number of modernizations for C++ 11 can be applied using the clang-tidy tool (former clang-modernize). This task will track the automatic improvements which will also fix some warnings. T23268 is related, but here we will only apply automatic fixes

Details

Differential Revisions
Restricted Differential Revision

Event Timeline

nolden created this task.Aug 24 2017, 12:07 PM
Ubuntu 17.10
sudo apt-get install clang-5.0 clang-tidy-5.0
cd MITK-superbuild/MITK-build
cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON .
/usr/lib/llvm-5.0/share/clang/run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-use-override' -fix
NOTE: Had to remove -Wstrict-null-sentinel from top-level and CppMicroServices CMakeLists.txt files before running clang-tidy. Didn't commit these changes, though.

We should test the branch above with the minimum supported versions of MSVC, GCC, and Clang. Tested successfully with GCC 7.2 so far.

nolden added a revision: Restricted Differential Revision.Mar 5 2018, 5:29 PM

Pushed new branch T23293-M_PI.

kislinsk claimed this task.Tue, Oct 15, 3:59 PM

Revive task.

This comment was removed by kislinsk.
kislinsk closed this task as Resolved.Wed, Oct 16, 2:03 PM