Page MenuHomePhabricator
Create Task
Maniphest T23293

Apply C++ 11 modernizations
Closed, ResolvedPublic
Actions

Assigned To
kislinsk
Authored By
nolden
Aug 24 2017, 12:07 PM
Tags
Referenced Files
None
Subscribers
kislinsk
nolden
Tokens
"Hungry Hippo" token, awarded by kislinsk.

Description

Quite a number of modernizations for C++ 11 can be applied using the clang-tidy tool (former clang-modernize). This task will track the automatic improvements which will also fix some warnings. T23268 is related, but here we will only apply automatic fixes

Revisions and Commits

Restricted Differential Revision

Related Objects

Event Timeline

nolden created this task.Aug 24 2017, 12:07 PM
kislinsk added a subscriber: kislinsk.Dec 22 2017, 12:49 AM

Pushed new branch T23293-modernize-use-override.

kislinsk added a comment.Dec 22 2017, 1:01 AM
Ubuntu 17.10
sudo apt-get install clang-5.0 clang-tidy-5.0
cd MITK-superbuild/MITK-build
cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON .
/usr/lib/llvm-5.0/share/clang/run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-use-override' -fix
NOTE: Had to remove -Wstrict-null-sentinel from top-level and CppMicroServices CMakeLists.txt files before running clang-tidy. Didn't commit these changes, though.

We should test the branch above with the minimum supported versions of MSVC, GCC, and Clang. Tested successfully with GCC 7.2 so far.

kislinsk mentioned this in rMITK1e11667f18ac: Merge branch 'T23293-modernize-use-override'.Dec 22 2017, 11:22 AM
nolden added a comment.Mar 5 2018, 5:03 PM

Pushed new branch T23293-more-modernizations-and-warning-fixes.

nolden added a revision: Restricted Differential Revision.Mar 5 2018, 5:29 PM
kislinsk added a comment.Mar 6 2018, 12:48 PM

Pushed new branch T23293-M_PI.

kislinsk mentioned this in rMITKc7022f5106ea: Merge branch 'T23293-M_PI'.Mar 6 2018, 12:49 PM
kislinsk awarded a token.Mar 6 2018, 1:00 PM
kislinsk added a comment.Mar 6 2018, 1:21 PM

Pushed new branch T23293-CannotConvertNullptrToDWORD.

kislinsk mentioned this in rMITK682330ad8d82: Merge branch 'T23293-CannotConvertNullptrToDWORD'.Mar 6 2018, 1:22 PM
nolden added a comment.Mar 8 2018, 2:57 PM

Pushed new branch T23293-modernization-fixup.

nolden mentioned this in rMITK81491e3f5dfb: Merge branch 'T23293-modernization-fixup'.Mar 8 2018, 2:58 PM
nolden mentioned this in rMITKcf75ee78bdd2: C++11 modernizations and warning fixes.Mar 14 2018, 2:23 AM
kislinsk claimed this task.Oct 15 2019, 3:59 PM

Revive task.

kislinsk added a comment.Oct 15 2019, 4:41 PM

Pushed new branch T23293-override-Oct2019.

kislinsk mentioned this in rMITK1fdbd9088049: Merge branch 'T23293-override-Oct2019'.Oct 15 2019, 4:55 PM
kislinsk mentioned this in rMITK5d99ddc4d7ed: Merge branch 'T23293-override-Oct2019'.Oct 16 2019, 12:35 PM
kislinsk mentioned this in rMITK3db51a382ace: Merge branch 'T23293-override-Oct2019'.Oct 16 2019, 1:03 PM
kislinsk added a comment.Oct 16 2019, 1:24 PM

Pushed new branch T23293-nullptr.

kislinsk mentioned this in rMITK43319a16964c: Merge branch 'T23293-nullptr'.Oct 16 2019, 1:30 PM
kislinsk added a comment.Oct 16 2019, 1:53 PM
This comment was removed by kislinsk.
kislinsk closed this task as Resolved.Oct 16 2019, 2:03 PM
nolden added a comment.Oct 22 2019, 5:33 PM

Thanks for picking up!

kislinsk mentioned this in rMITK86eb38db8a98: Merge branch 'T23293-nullptr'.Oct 23 2019, 1:52 PM
kislinsk mentioned this in T27033: Clean up stale remote branches.Jan 25 2020, 9:01 PM
MITK · MIC · IMSY · DKFZ