Build errors with clang 3.8.1 (Debian 9.1 "Stretch")
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	nolden
	Aug 17 2017, 5:06 PM

Description

Mostly warnings that turned into errors. @reicht probably these errors will affect Mac OS X at some point, so there is probaly some overlap with T23248 .

Revisions and Commits

	Restricted Differential Revision
	Restricted Differential Revision

Related Objects
Search...

Status	Assigned	Task
Resolved	nolden	T23268 Build errors with clang 3.8.1 (Debian 9.1 "Stretch")
Resolved	kislinsk	T23248 Prepare MITK for macOS 10.13 HighSierra support
		Restricted Maniphest Task
Resolved	kislinsk	T22929 Atomic operations API used in CppMicroServices are deprecated in macOS Sierra 10.12.5
Resolved	reicht	T23302 Build errors in MITK Utilities

Event Timeline

nolden created this task.Aug 17 2017, 5:06 PM

kislinsk added a subtask: T23248: Prepare MITK for macOS 10.13 HighSierra support.Aug 18 2017, 4:47 AM

nolden mentioned this in T23293: Apply C++ 11 modernizations.Aug 24 2017, 12:07 PM

reicht created subtask T23302: Build errors in MITK Utilities.Aug 25 2017, 8:56 AM

Pushed new branch T23268-clang-compilation-fixes.

nolden mentioned this in rMITK1808e1d5cc2a: Merge branch 'T23268-clang-compilation-fixes'.Aug 25 2017, 4:34 PM

nolden mentioned this in rMITK859d3e401a2c: Merge branch 'T23268-clang-compilation-fixes'.Aug 25 2017, 4:50 PM

Pushed new branch T23268-clang-compilation-fixes-clean.

nolden added a revision: Restricted Differential Revision.Aug 26 2017, 1:32 PM

@nolden changes can be committed beforehand into this MITK branch T23248-test-with-latest-master which has fixes so that DCMTK compiles on macOS with Clang.

nolden mentioned this in rMITKa2b4bf5fa494: Merge branch 'T23268-clang-compilation-fixes'.Aug 28 2017, 3:00 PM

Building current version of ITK fails with latest clang on macOS 10.13:

ep/src/ITK/Modules/ThirdParty/VNL/src/vxl/v3p/netlib/linalg/lsqrBase.cxx:565:14: error: ordered comparison between pointer and zero ('std::ostream *' (aka 'basic_ostream<char> *') and 'int')
    if (nout > 0)

In ITK 4.12.1 this is fixed, but for now the affected expression if (nout > 0) could be updated in MITKs ITK-4.11 patch file.

In T23248#107208, @reicht wrote:

additional patch in ITK-4.11.0.patch

diff --git a/CMakeExternals/ITK-4.11.0.patch b/CMakeExternals/ITK-4.11.0.patch
index 9a285c0..0bf2df5 100644
--- a/CMakeExternals/ITK-4.11.0.patch
+++ b/CMakeExternals/ITK-4.11.0.patch
@@ -20,3 +20,17 @@ index bf2d27d..e321215 100644
  endif()
  
  itk_module_impl()
+ 
+diff --git a/Modules/ThirdParty/VNL/src/vxl/v3p/netlib/linalg/lsqrBase.cxx b/Modules/ThirdParty/VNL/src/vxl/v3p/netlib/linalg/lsqrBase.cxx
+index 1f5f9bf..8c62db4 100644
+--- a/Modules/ThirdParty/VNL/src/vxl/v3p/netlib/linalg/lsqrBase.cxx
++++ b/Modules/ThirdParty/VNL/src/vxl/v3p/netlib/linalg/lsqrBase.cxx
+@@ -562,7 +562,7 @@ Solve( unsigned int m, unsigned int n, const double * b, double * x )
+     // See if it is time to print something.
+     //----------------------------------------------------------------
+     bool prnt = false;
+-    if (nout > 0)
++    if (nout > (void*)0)
+       {
+       if (n     <=        40) prnt = true;
+       if (this->itn   <=        10) prnt = true;
\ No newline at end of file

In T23248#107219, @kislinsk wrote:

An ordered comparison between a pointer and zero is very suspicious. Does it change the intended logic when replacing this with a comparison to nullptr, e.g. if (nout != nullptr)? Is it already fixed in ITK 4.12? If not, consider to contribute.

Or is there any other preferred solution?

Pushed new branch T23268-more-clang-fixes.

nolden added a revision: Restricted Differential Revision.Nov 13 2017, 8:28 AM

nolden mentioned this in rMITKc102a13cca53: More C++11 'override' additions.Nov 17 2017, 12:34 PM

nolden mentioned this in rMITK0b7158a90336: Merge branch 'T23268-more-clang-fixes'.Nov 21 2017, 5:55 PM

nolden mentioned this in rMITK69e45e2f9f0f: More C++11 'override' additions.