- Mentioned In
- T27486: Prepare changelog and migration guide for upcoming master merge
rMITKc6a443f12af4: Merge branch 'T26653-MasterIntegrationFixes'
rMITKa140adda1005: Merge branch 'T26653-ReenableDepthPeeling' into releases/2018-04
rMITKa9d670f8470c: Merge remote-tracking branch 'maleike/allow-vtk-depth-peeling' into T26653…
rMITK9d4583cf6466: Merge remote-tracking branch 'maleike/allow-vtk-depth-peeling' into T26653…
I re-enabled depth peeling support based on your pull request and also enabled depth peeling for volumes and FXAA. It works well for surfaces and volumes but totally breaks rendering of images/cross hair with opacity < 1. So this is not yet complete and I/we have to fix this before I am able to merge it.
All remaining issues solved by @maleike. I reintroduced the rendering mode preference but instead of switching between "Standard" (default, basically equivalent to "nothing") and "Depth Peeling" it now allows to switch between "No anti-aliasing" and "Fast Approximate Anti-Aliasing (FXAA)" (default). Depth peeling is always enabled as it only kicks in if there are translucent objects in the scene and in the worst case it is preferable to have not the fasted rendering instead of having a broken rendering. The future will show if we there is really a need to additionally add quality options regarding depth peeling.
Wow, I never noticed your comment here before I saw your reaction to the update on my GitHub pull request.. No idea why.. (checked all my mails and Phabricator settings)
Well anyways, thanks for integrating all of that and for your completion work! Perhaps I would have come up with the VTK patch earlier if I had seen your comment. I actually fixed vtkPropAssemblies because of a visualization issue completely unrelated to the crosshair.