Page MenuHomePhabricator
Create Task
Maniphest T26980

MITK_CREATE_MACRO should prohibit dependencies against autoload modules
Closed, ResolvedPublic
Actions

Description

Status: Currently you can depend a module on autoload modules. This is not correct and leads to problems like seen in T26976.
There should never be a need to directly depend on autoload modules as the provide implementation (e.g. io serivices), but the public interfaces one should depend on are provided by normal modules.

Proposed solution:

  • Every autoload module target has the target property "MITK_AUTOLOAD_DIRECTORY".
  • Thus check in the MITK_CREATE_MACRO if one of the modules specified by "DEPENDS" is an autoload module (has the target property "MITK_AUTOLOAD_DIRECTORY")
  • If this is the case an informative CMake error should be thrown.

Revisions and Commits

Restricted Differential Revision

Related Objects

Event Timeline

floca triaged this task as Normal priority.Jan 9 2020, 10:20 AM
floca created this task.
floca claimed this task.Jan 9 2020, 12:19 PM
floca added a comment.Jan 9 2020, 12:22 PM

Pushed new branch T26980-Prohibit_dependency_on_autoload_module.

floca mentioned this in rMITK3f52569e770a: First draft for fix of T26980.Jan 9 2020, 12:22 PM
kislinsk edited projects, added MITK (2018-04-4); removed MITK.Jan 9 2020, 2:52 PM
floca added a revision: Restricted Differential Revision.Jan 10 2020, 12:09 PM
kislinsk mentioned this in T27033: Clean up stale remote branches.Jan 25 2020, 9:00 PM
floca mentioned this in rMITK8a85321d889c: First draft for fix of T26980.Jan 30 2020, 8:46 AM
floca closed this task as Resolved.Jan 30 2020, 8:50 AM
floca added a project: Noteworthy.
floca added a subscriber: kislinsk.

@kislinsk You mentioned that we should do something as soon as the (wrong) autload dependencies are gone. I cannot remember what, do you? May be some work arround in our packaging code due to the autoload modules?

kislinsk added a comment.Jan 30 2020, 9:26 AM
In T26980#193572, @floca wrote:

@kislinsk You mentioned that we should do something as soon as the (wrong) autload dependencies are gone. I cannot remember what, do you? May be some work arround in our packaging code due to the autoload modules?

Yes, I think in the FixMacOS script is a loop that copies all autoload modules right into the bin folder. This shouldn't be necessary anymore and after removing it, it is a good indicator if the packaged macOS MITK Workbench starts without errors.

floca mentioned this in T27087: Remove Autoload-Modul-Workarround in the FixMacOS script.Feb 10 2020, 10:01 PM
kislinsk edited projects, added MITK; removed MITK (2018-04-4).Feb 11 2020, 4:42 PM
kislinsk mentioned this in T27243: DICOM plugin depends on autoload module.Mar 19 2020, 4:26 PM
kislinsk mentioned this in rMITK193d1d7b620c: Disallow dependencies to auto-load modules.Mar 23 2020, 10:41 AM
kislinsk mentioned this in rMITKf379735e54e5: In DICOM plugin, remove link-time dependency to auto-load DicomRTIO module.Mar 26 2020, 2:15 PM
kislinsk mentioned this in rMITK525971477cc1: In DICOM plugin, remove link-time dependency to auto-load DicomRTIO module.Mar 26 2020, 4:38 PM
kislinsk mentioned this in rMITKddb3c1bc348a: In DICOM plugin, remove link-time dependency to auto-load DicomRTIO module.Mar 27 2020, 9:47 AM
floca mentioned this in T27486: Prepare changelog and migration guide for upcoming master merge.Jun 22 2020, 9:57 PM
MITK · MIC · IMSY · DKFZ