Page MenuHomePhabricator
Create Task
Maniphest T27067

ImageCropper cannot crop some images (4d?)
Closed, ResolvedPublic
Actions

Description

I was not able to perform a cropping. Steps to reproduce:

  1. Start MITK in debug, load US4DCyl.nrrd and open the ImageCropper-plugin
  2. Select the loaded image in the datamanager
    • see how the UI of the plugin is enabled
  3. Create a new bounding shape
  4. Click on Crop

-> I get the message: The Cropping filter could not process because of: No overlap of the image and the cropping object.

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITKae05e678acfd <<Allow 4D image handling in Boundingshapecropper>

Related Objects

Event Timeline

kalali triaged this task as Normal priority.Feb 6 2020, 4:01 PM
kalali created this task.
kislinsk edited projects, added MITK (v2021.02); removed MITK.Apr 15 2020, 7:08 AM
kislinsk added a subscriber: kislinsk.

Can confirm with US4DCyl. Masking works however. @thomass Any idea?

kislinsk renamed this task from ImageCropper does not crop in Debug mode to ImageCropper cannot crop some images (4d?).Apr 15 2020, 7:09 AM
kislinsk updated the task description. (Show Details)
• thomass claimed this task.Apr 15 2020, 11:40 AM
• thomass added a comment.Apr 15 2020, 12:20 PM

Pushed new branch T27067-ImageCropperCorrect4D.

• thomass added a comment.EditedApr 15 2020, 12:22 PM

The reason seems to be that a BoundingShape as such is 3D with an index of size=3 that does not equal the index array of the 4D image. I will test the fix for other images to make sure.

• thomass added a revision: Restricted Differential Revision.Apr 22 2020, 1:05 PM
kislinsk raised the priority of this task from Normal to High.May 6 2020, 2:20 PM
kalali added a project: Cleared.May 8 2020, 10:36 AM
• thomass added a commit: rMITKae05e678acfd: <<Allow 4D image handling in Boundingshapecropper>.Jun 8 2020, 2:05 PM
• thomass lowered the priority of this task from High to Normal.Jun 8 2020, 2:14 PM
• thomass edited projects, added MITK; removed Cleared, MITK (v2021.02).

I will leave the task open since the handling in the respective class might need further refactoring to fully understand the behavior (as also mentioned by @kalali in the D279 review).
I remove the MITK2020 tag for now since the mentioned bug is resolved by the fix in D279.

• thomass closed this task as Resolved.Apr 27 2021, 4:34 PM

The task as such is resolved. Another task with open questions from D279 is created with T28466

kalali added a comment.May 11 2022, 3:22 PM

Deleted branch from rMITK MITK: T27067-ImageCropperCorrect4D.

MITK · MIC · IMSY · DKFZ