Page MenuHomePhabricator

Update external toolkits
Closed, ResolvedPublic


We should evaluate and discuss updates to the latest version of all external toolkits and if we want to update should probably do so as early as possible in the release process to get any functional changes covered by manual testing.

Event Timeline

nolden triaged this task as High priority.May 7 2020, 4:12 PM
nolden created this task.

Trivial should be:

  • Boost 1.74
  • GDCM 3.0.8
DependencyOld versionNew version
CTK78341aba (Dec 07, 2019)7210c5bc (Nov 08, 2020)
DCMQIea4f0809 (Jan 23, 2020)99192b76 (Nov 06, 2020)

Eigen update to v3.3.8 does not work. We have to wait for v3.3.9 which is going to be released in the next few days, according to

Our current version of ITK does not compile with OpenCV 3.4.12.

Poco 1.10.1 isn't a trivial update. It's known that Poco messes around with all the defines of Windows.h and there's a compiler definition POCO_NO_UNWINDOWS to control it that we use. However, something changed in Poco and all kinds of compiler and linker errors pop up even in unrelated modules and plugins as header declarations and implementations may differ, or method names are suddenly masked by definitions. It's hard to narrow it down as we seem to use a mix of both modes. So I call it a night for this task with all the updates mentioned above. Everything else is probably worth own dedicated tasks if necessary. The next big update we should focus on is ITK, though.

Deleted branch feature/T27383-UpdateExternalToolkits.

kislinsk added a project: Noteworthy.

All experimental CI clients succeeded. Merged into develop.