Page MenuHomePhabricator
Create Task
Maniphest T27700

Toolmanager multi instance support is not correctly integrated...
Closed, ResolvedPublic
Actions

Description

Check all calls of GetToolManager(*) and if everything is correct.

Allready identified issues:

  • SegmentationInteractor always uses the default toolmanager (and not e.g. the MultiLabel)
  • QmitkSurfaceStampWidget uses ML ToolManager in the constructor but in OnStamp() the default one.

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITKf1533e373758 Add missing tool manager context in ML segmentation
Restricted Differential RevisionrMITKe1a806155657 Add notes to class documentations regarding ToolManager context
Restricted Differential RevisionrMITKef6df59d006c Add missing tool manager context

Related Objects

Event Timeline

floca triaged this task as Unbreak Now! priority.Sep 2 2020, 5:17 PM
floca created this task.
floca moved this task from Backlog to Segmentation on the MITK (v2021.02) board.
kislinsk claimed this task.Sep 2 2020, 7:58 PM
kislinsk added a comment.Sep 2 2020, 8:15 PM
  • SegmentationInteractor is only used in ML Segmentation. I added the ML context.
  • I also added the ML context to the second call of GetToolManager() QmitkSurfaceStampWidget, it was simply forgotten

Still, after I added a segmentation, the classic Segmentation view immediately enables the tools widget, while I need to close and re-open the ML Segmentation view to see this effect. Investigating...

kislinsk added a comment.Sep 2 2020, 8:17 PM

Happens only the first time. When I delete all segmentations and then create another new segmentation, the tool widgets in both views are enabled. Might explain why I didn't notice it when doing D312, as I was sure that I tested this before.

kislinsk added a subscriber: • thomass.Sep 2 2020, 9:12 PM

Oh... @thomass just told me that there is also T27698: [Segmentation] Segmentation toolbox is never enabled in multi-label segmentation view where it is already resolved... nvm.

kislinsk added a revision: Restricted Differential Revision.Sep 2 2020, 9:18 PM
floca added a comment.Sep 2 2020, 9:23 PM
In T27700#209112, @kislinsk wrote:

Oh... @thomass just told me that there is also T27698: [Segmentation] Segmentation toolbox is never enabled in multi-label segmentation view where it is already resolved... nvm.

Sorry. Hopped that adding you as subscriber would be enough to inform you... Thanks for taking care of the rest!

kislinsk added a commit: rMITKef6df59d006c: Add missing tool manager context.Sep 3 2020, 10:11 AM
kislinsk added a commit: rMITKe1a806155657: Add notes to class documentations regarding ToolManager context.
kislinsk added a commit: rMITKf1533e373758: Add missing tool manager context in ML segmentation.
kislinsk closed this task as Resolved.Sep 3 2020, 10:11 AM
kislinsk mentioned this in T27784: 2020 Week 39 (Late September).Sep 25 2020, 12:56 PM
MITK · MIC · IMSY · DKFZ