Page MenuHomePhabricator

Create build-configuration for the MitkCLGlobalImageFeatures Miniapp (radiomics)
Closed, ResolvedPublic


We should have a build-configuration, which builds everything to run the MitkCLGlobalImageFeatures Miniapp.
It should be based on the current master (including the new export methods from @goetzm).

This will be used in the basic Radiomics-workflow of Kaapana and is of interest for multiple projects like HighMed, Racoon etc.

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision

Event Timeline

@schererj Do you mean the XML result export?

@goetzm Does the GIF mini app realy need the screenshot feature within the app (there is also a CLScreenshot app)?
Reason for the question is, that this feature is the only reason why Qt becomes dragged into the app and it bloats the container/deployment. Just wanted to now if we can the keep the configuration as slim as possible.

It really depends. I totally agree that it is not necessary for routine jobs, however it comes in really handy for controlling the data on remote locations were executing MITK is not possible/forbidden. That's why it had been build in.

We could wrap it in a #ifdef - structure which is activated by CMAKE / the availablility of the necessary dependencies. I think I would prefer this solution to just throw it out.
However, I would not keep it at every cost.

kislinsk triaged this task as Wishlist priority.Sep 8 2020, 10:14 AM
floca raised the priority of this task from Wishlist to High.Sep 8 2020, 11:15 AM

@goetzm Thanks for the feedback. I will have a look, if take that road or life with Qt dependency for now. Have to evaluate the impact in practice...

@schererj Do you mean the XML result export?

Yes, I thought it's JSON but XML is fine, too.

floca added a revision: Restricted Differential Revision.Sep 8 2020, 3:47 PM

Ok, for the beginning, to have a configuration as fast as possible for the kaapana release, I have kept Qt on board as dependency and not started to mess arround in code.

For now one needs the follwing infos to pass with cmake to have a one run superbuild that results in Classification cmd apps (including GIF).

-DQt5_DIR=<path to the Qt5 cmake instructions>

@floca I tried to build this configuration - but I cant find the executable.

It should be in mitk-bin/MITK-build/bin right?

The build-command in the Dockerfile looks like:

RUN cmake \
  -DMITK_BUILD_CONFIGURATION=ClassificationCmdApps  \
  -DCMAKE_INSTALL_PREFIX=/opt/install \
  ../mitk-src \
  && make -j"$(nproc)"

Maybe there is something wrong with that?

Edit: I built the master instead of the develop branch. -> I'll update this later