Page MenuHomePhabricator
Create Task
Maniphest T28060

CMake Policy CMP0091 does not work well with dependencies that are based on CMake version < 3.15
Closed, ResolvedPublic
Actions

Description

The CMake documentation states that the default new behavior matches the old behavior but we cannot confirm this as our dependencies are built with a non-debug runtime in debug configuration. As a quick but transient solution we should use the old behavior in all projects.

We should also create a minimum prototype to show the issue and report it to the CMake devs.

https://cmake.org/cmake/help/v3.18/policy/CMP0091.html
https://cmake.org/cmake/help/v3.18/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html

Related Objects

Event Timeline

kislinsk triaged this task as High priority.Dec 3 2020, 7:24 PM
kislinsk created this task.
kislinsk added a comment.Dec 3 2020, 7:27 PM

Pushed new branch bugfix/T28060-CMP0091.

kislinsk mentioned this in rMITKc32297641777: Merge branch 'bugfix/T28060-CMP0091' into develop.Dec 3 2020, 7:28 PM
kislinsk added a comment.Dec 3 2020, 7:28 PM

Deleted branch bugfix/T28060-CMP0091.

floca added a comment.Dec 3 2020, 9:32 PM

thanks for taking care. ❤

kislinsk closed this task as Resolved.Dec 4 2020, 12:42 PM
kislinsk reopened this task as Open.

Maybe I should leave this task open until we came up with a minimum prototype...

kislinsk lowered the priority of this task from High to Normal.Dec 4 2020, 12:43 PM
floca added a comment.EditedDec 4 2020, 3:33 PM

Thanks. No it works again.

In T28060#215620, @kislinsk wrote:

Maybe I should leave this task open until we came up with a minimum prototype...

From our process it would make sense to spawn a specific task for it. Otherwise we would miss it for the next changelog. wouldn't we?

kislinsk edited projects, added MITK; removed MITK (v2021.02).Dec 4 2020, 4:30 PM

It will be automatically listed in the changelog table regardless of the task status. :)

kislinsk closed this task as Resolved.Dec 7 2020, 8:15 PM
kislinsk mentioned this in T28126: 2020 Week 52 (Late December).Dec 21 2020, 5:16 AM
MITK · MIC · IMSY · DKFZ