Page MenuHomePhabricator
Create Task
Maniphest T29200

Completely remove QmitkFunctionality
Closed, ResolvedPublic
Actions

Description

The class was used as a base class for plugin views but has been replaced with QmitkAbstractView.
We should remove all the remnants of QmitkFunctionality (inside Plugins\org.mitk.gui.qt.common.legacy\src\).

As far as I can see the only classes that are not updated are QmitkIGTTrackingDataEvaluationView and QmitkIGTTrackingSemiAutomaticMeasurementView.
All other files only contain strings / references to the class but do not use it anymore.

Some classes inside rDIPP need to be checked as well.

API breaking changes
  • QmitkIGTTrackingDataEvaluationView does not subclass QmitkFunctionality anymore, but QmitkAbstractView instead
    • the functions MultiWidgetAvailable and MultiWidgetNotAvailable are not available anymore
  • QmitkIGTTrackingSemiAutomaticMeasurementView does not subclass QmitkFunctionality anymore, but QmitkAbstractView instead
    • the functions MultiWidgetAvailable and MultiWidgetNotAvailable are not available anymore

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit
rMITK MITK
Restricted Differential RevisionrMITK748211f61284 Remove QmitkFunctionality
Restricted Differential RevisionrMITK5a1a565bc552 Remove superfluous org.mitk.gui.qt.common.legacy plugin
Restricted Differential RevisionrMITKa9ad5b19e9ed Remove QmitkFunctionality and related classes
Restricted Differential RevisionrMITK35667162e55b Remove QmitkFunctionality from IGTTracking
Restricted Differential RevisionrMITK4e112b6b9616 Remove outdated comments containing QmitkFunctionality

Related Objects
Search...

Event Timeline

kalali triaged this task as Normal priority.Jun 3 2022, 8:54 AM
kalali created this task.
kalali added a parent task: T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor).Jun 3 2022, 9:04 AM
kalali mentioned this in T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor).
kalali updated the task description. (Show Details)Jun 7 2022, 9:06 PM
kalali updated the task description. (Show Details)Jun 8 2022, 9:23 AM
kalali claimed this task.Jun 8 2022, 9:29 AM
kalali added a revision: Restricted Differential Revision.Jun 8 2022, 9:36 AM
kalali added a commit: rMITK4e112b6b9616: Remove outdated comments containing QmitkFunctionality.Jun 29 2022, 8:21 AM
kalali added a commit: rMITK35667162e55b: Remove QmitkFunctionality from IGTTracking.
kalali added a commit: rMITK5a1a565bc552: Remove superfluous org.mitk.gui.qt.common.legacy plugin.
kalali added a commit: rMITKa9ad5b19e9ed: Remove QmitkFunctionality and related classes.
kalali added a commit: rMITK748211f61284: Remove QmitkFunctionality.
kalali closed this task as Resolved.Jun 29 2022, 8:31 AM
kalali updated the task description. (Show Details)
kalali moved this task from Backlog to Cycle on the MITK (v2022.10) board.
kalali added a project: Breaking Change.
kalali reopened this task as Open.Jun 29 2022, 8:40 AM
kalali added a revision: Restricted Differential Revision.
kislinsk mentioned this in T29226: 2022 Week 28 (Mid July).Jul 11 2022, 7:17 AM
kalali edited projects, added MITK, Next Milestone; removed MITK (v2022.10).Sep 7 2022, 5:17 PM
kalali added a commit: Restricted Diffusion Commit.Sep 7 2022, 7:02 PM
kalali closed this task as Resolved.Sep 7 2022, 7:03 PM
kalali updated the task description. (Show Details)
kalali edited projects, added MITK (v2022.10); removed Next Milestone, MITK.
MITK · MIC · IMSY · DKFZ