Page MenuHomePhabricator
Create Task
Maniphest T2927

Make 2D Geometries coordinate systems consistent with 3D
Closed, ResolvedPublic
Actions

Description

2D Geometries use center based index coordinates. This is not consistant with 3D, which use corner-based geometries.
Detailed discussion can be found in #2401.

Since no one uses (discrete) 2D index coordinates, this is not 3M3 relevant.
Changing may also cause some trouble with rendering.

Event Timeline

• schwarzt added projects: MITK, Bugzilla.Nov 11 2009, 7:41 PM
• schwarzt added a subscriber: • schwarzt.Nov 11 2009, 7:49 PM

Added change request. Requesting core mod.

Should maybe be more discussed in MITK meeting. (RFD)

maleike added a subscriber: maleike.Nov 12 2009, 9:40 AM

As I remember yesterday's discussion, your fix should wait until after 3M, because it might cause unexpected side effects (correct me if I'm wrong). I'm removing the needs_core_modification flag for now so that I get notified when it is requested again for comitting.

• schwarzt added a comment.Jan 13 2010, 3:56 PM

Trying to fix this today.
-> Requesting core mod again.

maleike added a comment.Jan 14 2010, 3:43 PM

Telephone call with Tobi:

  • he has already tested the change manually for a couple of cases like manual segmentation
  • he'll see that the unit test will follow
  • he'll discuss this topic with Ivo and propose to rewrite the mentioned function, e.g. by implementing it in the super class
• schwarzt added a comment.Jan 18 2010, 1:41 PM

[SVN revision 21076]
FIX (#2927): Make 2D index coordinates corner based.

• schwarzt added a comment.Feb 3 2010, 2:56 PM

[SVN revision 21199]
ADD (#2927): Simple test for coordinate system consistency

• schwarzt added a comment.Feb 3 2010, 3:02 PM

AbstractTransformGeometry already tests this more or less -> All tests added -> Closed.

MITK · MIC · IMSY · DKFZ