Page MenuHomePhabricator
Create Task
Maniphest T30332

Introduce toolbar visibility presets
Closed, ResolvedPublic
Actions

Description

Based on the new preference feature to control the visibility of categories (later maybe views) it should be possible to

  • Choose between different presets and this selection is also stored in the preferences
  • Nice To have: Allow custom definition of presets
  • Following presets should be available
    1. "Classical"/focused Workbench
    2. Perfusion Workbench
    3. All (this might not be a explicitly defined preset (because then we would need to always update it), but a different mode that allways activates everything.
  • Nice To Have: Presets also have a little description opton.

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITKdab7bea67b27 Improve function name
Restricted Differential RevisionrMITK0761b60817c9 Allow showing Preferences dialog with a specific initial page
Restricted Differential RevisionrMITK51afc73671d6 Add startup dialog for optional preset selection
Restricted Differential RevisionrMITK87d7f6fb181b Add presets as resources
Restricted Differential RevisionrMITK1459d22287d0 Improve appearance of disabled QAbstractItemViews in dark style
Restricted Differential RevisionrMITK5308a85a023b Execute startup dialog
Restricted Differential RevisionrMITKdf81a482ceac Add code comments
Restricted Differential RevisionrMITK7125f2653a44 Add comment about the (for now) internal preset file format
Restricted Differential RevisionrMITK5f7a3eab7967 Prepend preset name as header to preset info
Restricted Differential RevisionrMITK1fabbff0ffd5 Do not execute startup dialog if it should be skipped
Restricted Differential RevisionrMITK18b6a5be1202 Move GetViewsByCategory() to berry::IViewRegistry
Restricted Differential RevisionrMITK6beae5b17276 Move GetToolBars() to berry::IWorkbenchWindow
Restricted Differential RevisionrMITKa64083b3d4dc Apply chosen startup preset
Restricted Differential RevisionrMITK8458d18eba85 Fix typo
Restricted Differential RevisionrMITK5341a437b1b1 Add Application Startup preference page
Restricted Differential RevisionrMITK3c815be3ae64 Fix Clang and GCC compile errors

Related Objects
Search...

Event Timeline

floca triaged this task as Normal priority.Feb 18 2024, 8:53 PM
floca created this task.
floca added a subtask: T30284: Control category/view toolbar visibility through preferences.
floca mentioned this in T30333: Add introductory startup dialog or Welcome page.Feb 18 2024, 9:18 PM
floca added a parent task: T30333: Add introductory startup dialog or Welcome page.
kislinsk closed subtask T30284: Control category/view toolbar visibility through preferences as Resolved.Feb 19 2024, 2:55 PM
kislinsk added a comment.Apr 16 2024, 11:31 PM

The current state of presets/a startup dialog is as follows:

Screenshot 2024-04-16 231843.png (392×482 px, 14 KB)

Its appearance is a little dull but essential and IMHO fine for a first version. Basically all requirements from above are fulfilled with pretty minimum code at the moment. We need to define a feature freeze, though, as there are many possibilities for further extensions and improvements. For example, currently the predefined presets are defined in code, while the "custom" option forwards to the "Tool Bars" preference page to customize visible plugins resp. categories. Also, the presets are limited to plugins/categories. In future we may also want to utilize command-line arguments to set a (serialized) preset.

The last mandatory part missing in the current iteration is to actually apply the presets. Therefore I want to refactor a little bit of the code from the Tool Bars preference page to have easy access to categories from modules.

kislinsk claimed this task.Apr 19 2024, 12:23 AM
kislinsk added a comment.Apr 19 2024, 12:32 AM

Pushed new branch to rMITK MITK: feature/T30332-ToolBarPresets.

kislinsk added a comment.Apr 19 2024, 12:41 AM

Presets are now loaded at runtime from the :/org_mitk_presets resource path. They can build upon each other, e.g., the ModelFit preset just adds the Fitting and Perfusion categories to the categories of the Classic preset.

Also, everything moved from module to plugin level since we need to talk to BlueBerry.

Still, actually applying the selected preset is missing and a separate preference page for startup, on which one could tick "Show startup dialog" again, after ticking "Do not show this dialog again" in the startup dialog. As the startup dialog or something equivalent will gain some more features after the upcoming release, more preferences will be necessary anyways.

kislinsk added a comment.EditedApr 19 2024, 3:31 PM

Presets are now applied. So everything major is completed. Last thing missing is the startup preference page. Also, while working on that, another requirement in that regard is to consolidate tool bar preferences into a single preference page, which seems to be split in two pages at the moment.

edit: Tool bar preferences are already on a single common page.

kislinsk added a revision: Restricted Differential Revision.Apr 22 2024, 9:26 AM
kislinsk mentioned this in rMITKbcb888d6510f: Merge branch 'feature/T30332-ToolBarPresets' into develop.Apr 25 2024, 10:40 AM
kislinsk added a commit: rMITK3c815be3ae64: Fix Clang and GCC compile errors.
kislinsk added a commit: rMITK5341a437b1b1: Add Application Startup preference page.
kislinsk added a commit: rMITK8458d18eba85: Fix typo.
kislinsk added a commit: rMITKa64083b3d4dc: Apply chosen startup preset.
kislinsk added a commit: rMITK1fabbff0ffd5: Do not execute startup dialog if it should be skipped.
kislinsk added a commit: rMITK6beae5b17276: Move GetToolBars() to berry::IWorkbenchWindow.
kislinsk added a commit: rMITK18b6a5be1202: Move GetViewsByCategory() to berry::IViewRegistry.
kislinsk added a commit: rMITK7125f2653a44: Add comment about the (for now) internal preset file format.
kislinsk added a commit: rMITK5f7a3eab7967: Prepend preset name as header to preset info.
kislinsk added a commit: rMITKdf81a482ceac: Add code comments.
kislinsk added a commit: rMITK5308a85a023b: Execute startup dialog.
kislinsk added a commit: rMITK51afc73671d6: Add startup dialog for optional preset selection.
kislinsk added a commit: rMITK87d7f6fb181b: Add presets as resources.
kislinsk added a commit: rMITK1459d22287d0: Improve appearance of disabled QAbstractItemViews in dark style.
kislinsk added a commit: rMITK0761b60817c9: Allow showing Preferences dialog with a specific initial page.
kislinsk added a commit: rMITKdab7bea67b27: Improve function name.
kislinsk added a comment.Apr 25 2024, 10:41 AM

Deleted branch from rMITK MITK: feature/T30332-ToolBarPresets.

kislinsk closed this task as Resolved.Apr 25 2024, 10:41 AM
kislinsk mentioned this in T30407: 2024 Week 18 (Very Early May).May 2 2024, 7:56 AM
MITK · MIC · IMSY · DKFZ