Page MenuHomePhabricator

mitk::ImageStatisticsCalculator crash on selection of diffusion datasets
Closed, ResolvedPublic

Assigned To
None
Authored By
fritzsck
Nov 25 2009, 6:51 PM
Referenced Files
F401: Qballs.qbi
Jan 20 2010, 7:07 PM
F400: Tensoren.dti
Jan 20 2010, 7:07 PM
F399: Diffusion.dwi
Jan 20 2010, 7:07 PM

Event Timeline

fritzsck added a subscriber: fritzsck.

[SVN revision 20565]
FIX (#3098): ommitting data sets from diffusion imaging

Not a very clean solution, since MitkExt should not know anything about diffusion datasets. Will leave the bug open.

Assigning this to default assignee because mbi-bug-manager is not a person and cannot evaluate/reassign this bug. Would you please assign it to the correct product/component and estimate whether it is relevant for the 1.0 release? Thank you.

ImageStatisticsCalculator will be moved to open source for MITK-1-0 (T3207)

Klaus, does this bug then becaome relevant for this release?

Yes, it definetively should not crash. But that should be fixed already, shouldn't it? I am not sure, if we want a "clean" solution for the release.

Mathias, lets talk about the bug personally. The problem that MitkExt should not know anything about diffusion datasets (because those are only introduced by an external module) is a principle problem and not directly related to statistics or diffusion imaging code.

I am not sure if this is really something we want to target for the release.

If you are discussing it, please also assign it to one of you. If it needs to be discussed in the MITK meeting, please set the RFD keyword.

If it still crashes it is relevant. A clean solution is not strictly necessary

Mathias, could you check for crashes in the statistics tool? I will attach example data sets.

Diffusion dataset

Adding block on T3207 (make ImageStatistics open source)

(In reply to comment #9)

Mathias, could you check for crashes in the statistics tool? I will attach
example data sets.

Klaus, I tested the bundle with the provided datasets and everything seems okay, the application does not crash any longer.

I was wondering if instead of testing for class names and rejecting the diffusion datasets explicitly, could we not just check if the number of components of the image is > 1? I quickly tried this and it works fine.

In fact, the dataset "Diffusion.dwi" seems to have only one image component, and the statistics module outputs something. I'm not sure if this is correct, could you check this?

Testing for number of components instead of explicitly rejecting types also has the advantage that RGB images are excluded as well (since statistics also doesn't work in this case).

If you don't see any problem with this, I'd check in the modified code.

Great, that we don't get crashes any more.
Diffusion.dwi is one slice with 14x25 voxels and 253 components.
Checking for multiple components instead of types sound good to me.

[SVN revision 21573]
ENH (#3098): Refuse images with more than one component for statistics calculation instead of specific types (this is done in QmitkImageStatisticsView, see r21572 and T3067)

Merging "applicazion modules" component with "ExtApp plugins"