Page MenuHomePhabricator

Color property pop-up window not shown again after closing
Closed, InvalidPublic

Description

How to reproduce:

Open the color dialog through a click on the color cell in the 'PropertyList' GUI Table, close this Dialog with 'Cancel'. Click on the same cell in the table.

Expected behaviour:
The color dialog window is shown again.

Observed behaviour:
The dialog window does not appear, first after clicking on another 'color property' cell. Moreover the color property is reset to gray when closing with 'Cancel'

Event Timeline

After clicking "OK" you can not directly open the same property's dialog either

The color button is replaced by a new one which used a default color if the QColorDialog returned invalid. Changed that behavior to keeping the previous color.

Added change request.

Michi, you wrote most of the code, do you know where the problem might stem from?

[SVN revision 24448]
FIX (#4575): Reassigning previous color if cancel is pressed

reinspected the behaviour. unfortunately, it cannot be changed as the workflow is dictated by the qt model view framework. by the time the user has chosen a color from the dialog, he cannot further interact with the button. He has to click somewhere else or press enter to accept the changes. then he can interact with the button again.
the only other solution is to not take a coloured button but rather a combobox or something like that but this is far not as comfortable as this color dialog

kislinsk changed the task status from Invalid to Spite.Jun 27 2018, 1:33 PM
kislinsk added a project: Bulk Edit.
kislinsk changed the task status from Spite to Invalid.Jun 27 2018, 1:37 PM
kislinsk removed a project: Bulk Edit.