Page MenuHomePhabricator
Create Task
Maniphest T7620

Expect GDCM 2.0.14 minimum for DICOM loading
Closed, ResolvedPublic
Actions

Description

For discussion in an MITK meeting:

Should we drop support for DICOMImageIO and GDCM prior to 2.0.14?

Keeping code for these two options

  • makes DicomSeriesReader more complicated than it would need to be
    • ok, this could be refactored to be readable
  • multiplies failure possibilities
    • I doubt we have enough developers to support all possibilities (people willing to touch this piece of code are already rare)
  • requires a couple of nightly dartclients to be configured and maintained to actually test our support

CC a couple of people that I suspect to work with DICOM images.

Related Objects
Search...

Event Timeline

maleike added projects: MITK, Bugzilla.Apr 5 2011, 5:02 PM
maleike added a subscriber: maleike.Apr 12 2011, 12:34 PM

So, the MITK meeting this morning agreed that we could drop support for versions prior to 2.0.14. We must just make sure that CMake detect other versions and complains loud enough.

maleike added a comment.Apr 26 2011, 6:01 PM

Two weeks and no objections. I'll remove options other than GDCM 2.0.14

maleike added a comment.May 2 2011, 2:35 PM

Change request written. Branch won't take long, it's mostly a check for at least GDCM 2.0.14

maleike added a comment.May 2 2011, 3:22 PM

Check implemented and pushed to branch bug-7620-bye-DICOMIO

maleike added a comment.May 3 2011, 10:17 AM

[811799]: Merge branch 'bug-7620-bye-DICOMIO'

Merged commits:

2011-05-03 10:03:14 Daniel Maleike [24b6aa]
Even more code blocks depending of a GDCM define

2011-05-02 14:55:46 Daniel Maleike [144c3b]
Verify with CMake that we get at least GDCM 2.0.14

2011-05-02 14:14:52 Daniel Maleike [b2505a]
Expect GDCM > 2.0 ; keep spacing workaround for 2.0.14

2011-05-02 13:51:58 Daniel Maleike [3a138b]
Expect GDCM > 2.0

2011-05-02 13:45:37 Daniel Maleike [9e9d8c]
Assume GDCMIO the default

maleike added a comment.May 3 2011, 10:19 AM

MITK (Core) now compiles only with GDCM >= 2.0.14. still master compiles successfully with some GDCM < 2.0.14 code removed from DicomSeriesReader and the Diffusion Imaging module.

MITK · MIC · IMSY · DKFZ