Page MenuHomePhabricator

Implement ClippedSurfaceBoundsCalculator
Closed, ResolvedPublic

Description

A class for finding the currently displayed slices of an mitk::Image should be
implemented. The class gets as input a Geometry2D and an Image. It then calculates the minimum and maximum slices for three spatial directions (x,y, z). Internally it uses the Geometry2DDataToSurfaceFilter class to create a surface of the 2D geometry. Each polygon point is checked and the min/max bounds updated accordingly.

Event Timeline

Implemented class ClippedSurfaceBoundsCalculator. The class Geometry2DDataToSurfaceFilter wasn't used to get the polygon points. Instead the ClippedSurfaceBoundsCalculator class has its own method to get the intersection points between a PlaneGeometry and a Geometry3D.

Unittest still needs to be implemented.

[f0bed2]: Merge branch 'bug-8664-implement-clipped-surface-bounds-calculator'

Merged commits:

2011-07-06 16:09:57 Danial Bin Mohamed Saruji [abd54d]
implemented new class ClippedSurfaceBoundsCalculator


2011-07-06 15:56:58 Danial Bin Mohamed Saruji [762569]
Merge branch 'bug-7528-test-dicom-tags-loading-image-properties'


2011-07-06 15:56:54 Danial Bin Mohamed Saruji [2b153a]
Merge branch 'bug-7339-provide-dicom-tags-as-image-property'

[548a38]: Merge branch 'bug-8664-implement-clipped-surface-bounds-calculator'

Merged commits:

2011-07-07 14:04:26 Danial Bin Mohamed Saruji [8eebd5]
COMP: Wrong EXPORT MACRO changed to MITK_CORE_EXPORT

[1c20dd]: Merge branch 'bug-8664-implement-clipped-surface-bounds-calculator'

Merged commits:

2011-07-07 15:05:47 Danial Bin Mohamed Saruji [20b742]
fix: map needs to be cleared when new input is given

[36b99f]: Merge branch 'bug-8664-implement-clipped-surface-bounds-calculator'

Merged commits:

2011-07-15 15:16:47 Danial Bin Mohamed Saruji [d0eac7]
code cleanup and enhancement of calculation


2011-07-15 15:16:15 Danial Bin Mohamed Saruji [aece8d]
Vectors shouldn't be normalized to get values between 0 and 1 for t


2011-07-07 18:41:48 Danial Bin Mohamed Saruji [33981d]
fix: check should check if point is on image

Mostly code cleanup. Also not the isIndexInside method is used to check if the point is inside the boundaries of the image. Instead the method intersectionPointParam from class PlaneGeometry is used which gives a double value between 0 and 1 if the intersection point is between the start and the end point of the line we are intersecting with. The method intersectionPointParam had to be fixed: the vectors planeNormal and lineDirection shouldn't be normalized to get values between 0 and 1.

I checked the code and found it mostly undocumented. Since we planned the class together, I wrote the documentation myself and will push it shortly. Also reduced the number of included headers and initialized the output variables which are returned without checking for their existence.

[270150]: Merge branch 'bug-8664-implement-clipped-surface-bounds-calculator'

Merged commits:

2011-07-29 11:27:27 Daniel Maleike [a76bae]
Provide documentation, more structure, and initialization.

[9e34fc]: Merge branch 'bug-8664-implement-clipped-surface-bounds-calculator'

Merged commits:

2011-07-18 15:44:24 Danial Bin Mohamed Saruji [20f8a0]
implemented unittest for mitkClippedSurfaceBoundsCalculatorTest

Test looks sensible and right, but to clarify that for readers half a year from now, please add a short summary of what it is actually doing to implement what kind of test.

[d27c22]: Merge branch 'bug-8664-implement-clipped-surface-bounds-calculator'

Merged commits:

2011-08-03 17:30:03 Danial Bin Mohamed Saruji [240445]
added short summary to unittest