T27621/T27622 - Corrected threshold tools
08619e4fc4b8
Actions

Description

T27621/T27622 - Corrected threshold tools

Summary:
Add (event) support for current time point change to toolmanager

first draft of threshold tool that behaves correctly time point aware now.

Refactored threshold tools to remove redundant code (introduce one base class with the whole logic)

+ Removed dead code
+ Simplified logic of QmitkBinaryThresholdToolGui

Corrected mitk::AutoSegmentationTool::GetTargetSegmentationNode() to use the current segementation as template if a new segmentation should be generated.

Improved usablility of threshold tools

replaced dialog by checkbox
for dynamic segmentations added option to process all time steps

Removed unnecessary call

Test Plan: code review and check list / application test of tool behavior

Reviewers: O1 MITK Reviewer Group I, thomass, kislinsk

Reviewed By: O1 MITK Reviewer Group I, kislinsk

Subscribers: kislinsk, kalali

Maniphest Tasks: T27621, T27622

Differential Revision: https://phabricator.mitk.org/D376

Details

Provenance

floca	Authored on Aug 4 2020, 8:06 PM
floca	Pushed on Aug 5 2020, 10:19 AM

Reviewer

O1: MITK Reviewer Group I

Differential Revision

Restricted Differential Revision

Parents

rMITK5f96821de19f: Fixed review remarks.
rMITKeed36131e0f8: T27117 Revised the docu of matchpoint.algorithm.control

Branches

Unknown

Tags

Unknown

Tasks

T27621: [Segmentation] 3D Threshold / UL Threshold does not use a timestep != 0 for static masks
T27622: [Segmentation] Make 3D Threshold / UL Threshold only for on a single timestep for a dynamic mask

Event Timeline

floca committed rMITK08619e4fc4b8: T27621/T27622 - Corrected threshold tools (authored by floca).Aug 5 2020, 10:20 AM

floca added an edge: Restricted Differential Revision.

floca added tasks: T27622: [Segmentation] Make 3D Threshold / UL Threshold only for on a single timestep for a dynamic mask, T27621: [Segmentation] 3D Threshold / UL Threshold does not use a timestep != 0 for static masks.

kislinsk mentioned this in T27695: 2020 Week 36 (Very Early September).Sep 1 2020, 3:34 PM

Merged Changes

5f96821de19f Fixed review remarks.
Author
floca
Browse Repository
No Builds
No Audits
c03ca0616159 Handeled unused variables (gcc error)
Author
floca
Browse Repository
No Builds
No Audits
4408a8ff26b0 Removed unnecessary call
Author
floca
Browse Repository
No Builds
No Audits
179b53dfa7bb Improved usablility of threshold tools
Author
floca
Browse Repository
No Builds
No Audits
b9bfb2ec4e41 Corrected mitk::AutoSegmentationTool::GetTargetSegmentationNode() to use the…
Author
floca
Browse Repository
No Builds
No Audits
703af31f270f Refactored threshold tools to remove redundant code
Author
floca
Browse Repository
No Builds
No Audits
13895dc2f6b7 first draft of threshold tool that behaves correctly time point aware now.
Author
floca
Browse Repository
No Builds
No Audits
83f54f57a53c Add (event) support for current time point change to toolmanager
Author
floca
Browse Repository
No Builds
No Audits

Changes (14)

Path

Size

Packages

Modules/

Segmentation/

Controllers/

mitkToolManager.cpp

O1: MITK Reviewer Group I

mitkToolManager.h

O1: MITK Reviewer Group I

Interactions/

mitkAutoSegmentationTool.cpp

O1: MITK Reviewer Group I

	mitkBinaryThresholdBaseTool.cpp
	mitkBinaryThresholdULTool.cpp

O1: MITK Reviewer Group I

mitkBinaryThresholdBaseTool.h

O1: MITK Reviewer Group I

mitkBinaryThresholdTool.cpp

O1: MITK Reviewer Group I

mitkBinaryThresholdTool.h

O1: MITK Reviewer Group I

mitkBinaryThresholdULTool.cpp

O1: MITK Reviewer Group I

mitkBinaryThresholdULTool.h

O1: MITK Reviewer Group I

files.cmake

O1: MITK Reviewer Group I

SegmentationUI/

Qmitk/

QmitkBinaryThresholdToolGUI.cpp

O1: MITK Reviewer Group I

QmitkBinaryThresholdToolGUI.h

O1: MITK Reviewer Group I

QmitkBinaryThresholdULToolGUI.cpp

O1: MITK Reviewer Group I

QmitkBinaryThresholdULToolGUI.h

O1: MITK Reviewer Group I

rMITK08619e4fc4b8

View Options

Modules/Segmentation/Controllers/mitkToolManager.cpp

View Options

Modules/Segmentation/Controllers/mitkToolManager.h

View Options

Modules/Segmentation/Interactions/mitkAutoSegmentationTool.cpp

View Options

Modules/Segmentation/Interactions/mitkBinaryThresholdBaseTool.cpp

View Options

Modules/Segmentation/Interactions/mitkBinaryThresholdBaseTool.h

View Options

Modules/Segmentation/Interactions/mitkBinaryThresholdTool.cpp

View Options

Modules/Segmentation/Interactions/mitkBinaryThresholdTool.h

View Options

Modules/Segmentation/Interactions/mitkBinaryThresholdULTool.cpp

View Options

Modules/Segmentation/Interactions/mitkBinaryThresholdULTool.h

View Options

Modules/Segmentation/files.cmake

View Options

Modules/SegmentationUI/Qmitk/QmitkBinaryThresholdToolGUI.cpp

View Options

Modules/SegmentationUI/Qmitk/QmitkBinaryThresholdToolGUI.h

View Options

Modules/SegmentationUI/Qmitk/QmitkBinaryThresholdULToolGUI.cpp

View Options

Modules/SegmentationUI/Qmitk/QmitkBinaryThresholdULToolGUI.h

T27621/T27622 - Corrected threshold tools08619e4fc4b8Actions

Description

Details

Event Timeline

Merged Changes

Changes (14)

rMITK08619e4fc4b8

Modules/Segmentation/Controllers/mitkToolManager.cpp

Modules/Segmentation/Controllers/mitkToolManager.h

Modules/Segmentation/Interactions/mitkAutoSegmentationTool.cpp

Modules/Segmentation/Interactions/mitkBinaryThresholdBaseTool.cpp

Modules/Segmentation/Interactions/mitkBinaryThresholdBaseTool.h

Modules/Segmentation/Interactions/mitkBinaryThresholdTool.cpp

Modules/Segmentation/Interactions/mitkBinaryThresholdTool.h

Modules/Segmentation/Interactions/mitkBinaryThresholdULTool.cpp

Modules/Segmentation/Interactions/mitkBinaryThresholdULTool.h

Modules/Segmentation/files.cmake

Modules/SegmentationUI/Qmitk/QmitkBinaryThresholdToolGUI.cpp

Modules/SegmentationUI/Qmitk/QmitkBinaryThresholdToolGUI.h

Modules/SegmentationUI/Qmitk/QmitkBinaryThresholdULToolGUI.cpp

Modules/SegmentationUI/Qmitk/QmitkBinaryThresholdULToolGUI.h

T27621/T27622 - Corrected threshold tools
08619e4fc4b8
Actions