Diffusion MITK 327fda395735

crosshair on new segmentation…
327fda395735
Actions

Description

Preserve view position / do not reset camera / crosshair on new segmentation creation.

Summary:
Remove unnecessary include

Use early return to make the function more readable

Minimize the scope of the try-catch block

Store and reset the crosshair position after view initialization

Test Plan: manual

Reviewers: kislinsk, floca, O1 MITK Reviewer Group I

Reviewed By: floca, O1 MITK Reviewer Group I

Subscribers: kleina

Tags: Breaking Change

Maniphest Tasks: T28490

Differential Revision: https://phabricator.mitk.org/D523

Details

Provenance

kalali	Authored on Aug 9 2021, 4:00 PM
kalali	Pushed on Aug 12 2021, 3:34 PM

Reviewer

O1: MITK Reviewer Group I

Differential Revision

Restricted Differential Revision

Parents

rMITK749614ce69af: Preserve view position in multi label plugin view
rMITK8186562db1a4: Fixed T28492 PACS interaction getting stuck from modifier keys

Branches

Unknown

Tags

Unknown

Tasks

T28490: Segmentation plugin: "new" segmentation should not run reinit!

Event Timeline

kalali committed rMITK327fda395735: Preserve view position / do not reset camera / crosshair on new segmentation… (authored by kalali).Aug 12 2021, 3:34 PM

kalali added a task: T28490: Segmentation plugin: "new" segmentation should not run reinit!.

kalali added an edge: Restricted Differential Revision.

kislinsk mentioned this in T28713: 2021 Week 39 (Very Early October).Oct 1 2021, 10:25 AM

Merged Changes

749614ce69af Preserve view position in multi label plugin view
Author
kalali
Browse Repository
No Builds
No Audits
5dab8efe3757 Move view position preservation to base class
Author
kalali
Browse Repository
No Builds
No Audits
f7598135a1b9 Add parameter / condition to check if the camera should be reset
Author
kalali
Browse Repository
No Builds
No Audits
ae487e0fca76 Store and reset the crosshair position after view initialization
Author
kalali
Browse Repository
No Builds
No Audits
b2700926a04f Minimize the scope of the try-catch block
Author
kalali
Browse Repository
No Builds
No Audits
45620b14c1ff Use early return to make the function more readable
Author
kalali
Browse Repository
No Builds
No Audits
7187bde37d7e Remove unnecessary include
Author
kalali
Browse Repository
No Builds
No Audits

Changes (11)

Path

Size

Packages

Modules/

Core/

include/

mitkRenderingManager.h

O1: MITK Reviewer Group I

src/

Controllers/

mitkRenderingManager.cpp

O1: MITK Reviewer Group I

SegmentationUI/

Qmitk/

QmitkFastMarchingToolGUI.cpp

O1: MITK Reviewer Group I

QmitkLiveWireTool2DGUI.cpp

O1: MITK Reviewer Group I

QmitkPaintbrushToolGUI.cpp

O1: MITK Reviewer Group I

Plugins/

org.mitk.gui.qt.application/

src/

QmitkDataNodeReinitAction.cpp

O1: MITK Reviewer Group I

org.mitk.gui.qt.common/

src/

QmitkAbstractView.cpp

O1: MITK Reviewer Group I

QmitkAbstractView.h

O1: MITK Reviewer Group I

org.mitk.gui.qt.multilabelsegmentation/

src/

internal/

QmitkMultiLabelSegmentationView.cpp

QmitkMultiLabelSegmentationView.h

org.mitk.gui.qt.segmentation/

src/

internal/

QmitkSegmentationView.cpp

O1: MITK Reviewer Group I

rMITK327fda395735

View Options

Modules/Core/include/mitkRenderingManager.h

View Options

Modules/Core/src/Controllers/mitkRenderingManager.cpp

View Options

Modules/SegmentationUI/Qmitk/QmitkFastMarchingToolGUI.cpp

View Options

Modules/SegmentationUI/Qmitk/QmitkLiveWireTool2DGUI.cpp

View Options

Modules/SegmentationUI/Qmitk/QmitkPaintbrushToolGUI.cpp

View Options

Plugins/org.mitk.gui.qt.application/src/QmitkDataNodeReinitAction.cpp

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkAbstractView.cpp

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkAbstractView.h

View Options

Plugins/org.mitk.gui.qt.multilabelsegmentation/src/internal/QmitkMultiLabelSegmentationView.cpp

View Options

Plugins/org.mitk.gui.qt.multilabelsegmentation/src/internal/QmitkMultiLabelSegmentationView.h

View Options

Plugins/org.mitk.gui.qt.segmentation/src/internal/QmitkSegmentationView.cpp

Preserve view position / do not reset camera / crosshair on new segmentation…327fda395735Actions

Description

Details

Event Timeline

Merged Changes

Changes (11)

rMITK327fda395735

Modules/Core/include/mitkRenderingManager.h

Modules/Core/src/Controllers/mitkRenderingManager.cpp

Modules/SegmentationUI/Qmitk/QmitkFastMarchingToolGUI.cpp

Modules/SegmentationUI/Qmitk/QmitkLiveWireTool2DGUI.cpp

Modules/SegmentationUI/Qmitk/QmitkPaintbrushToolGUI.cpp

Plugins/org.mitk.gui.qt.application/src/QmitkDataNodeReinitAction.cpp

Plugins/org.mitk.gui.qt.common/src/QmitkAbstractView.cpp

Plugins/org.mitk.gui.qt.common/src/QmitkAbstractView.h

Plugins/org.mitk.gui.qt.multilabelsegmentation/src/internal/QmitkMultiLabelSegmentationView.cpp

Plugins/org.mitk.gui.qt.multilabelsegmentation/src/internal/QmitkMultiLabelSegmentationView.h

Plugins/org.mitk.gui.qt.segmentation/src/internal/QmitkSegmentationView.cpp

Preserve view position / do not reset camera / crosshair on new segmentation…
327fda395735
Actions