HomePhabricator
Diffusion MITK 6c54f2b353f4

Merge branch 'T19830-fixing-rendering-of-arbitraryTimeGeometries-snapshot'…

This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Merge branch 'T19830-fixing-rendering-of-arbitraryTimeGeometries-snapshot' into personal/engelm/snapshot-201606

Details

Provenance
engelmAuthored on Aug 4 2016, 10:07 AM
engelmPushed on Aug 4 2016, 10:07 AM

Event Timeline

Just a short comment/question after a quick look through the changes.

/Modules/Core/include/mitkArbitraryTimeGeometry.h
237–239

Is your change of the model intended? The old version does not model gaps. So one time step allways streches till the next one starts. (Like ProportionalTime geometry behaves). Your implementation allows gaps between the timesteps, because the "coverage" of the time steps may not be connected anymore.

It feels like it is different to how MITK handles time geomtries so far.

@nolden: What do you think?

If we stay with the new behaviour the class documentation and unit tests should be adapted as well, becaouse they do not reflect it currently.

Commit No Longer Exists

This commit no longer exists in the repository.