HomePhabricator
Diffusion MITK 748b94b4186d

Merge enums for view direction

Description

Merge enums for view direction

Summary:
Replace ViewDirection and PlaneOrientation with AnatomicalPlane

API breaking changes

Remove the ViewDirection enum from the BaseRenderer
and use the new AnatomicalPlane enum class for the
different directions / planes.
Remove the ViewDirection enum from the SliceNavigationController
and use the new AnatomicalPlane enum class for the
different directions / planes.
Remove the PlaneOrientation enum from the PlaneGeometry
and use the new AnatomicalPlane enum class for the
different orientations / planes.

Migration should be easy, since the different directions / planes /
orientations are the same and in the same order as before.
"ViewDirection::THREE_D" is now "AnatomicalPlane::Original".
"PlaneOrientation::None" is now "AnatomicalPlane::Original".

Test Plan: compile testing

Reviewers: kislinsk, floca, O1 MITK Reviewer Group I, O3 MITK Reviewer Group II

Reviewed By: floca, O1 MITK Reviewer Group I, O3 MITK Reviewer Group II

Subscribers: floca, kalali, kislinsk

Tags: Breaking Change, Noteworthy

Maniphest Tasks: T26543

Differential Revision: https://phabricator.mitk.org/D753

Details

Provenance
kalaliAuthored on Nov 9 2022, 4:03 PM
kalaliPushed on Nov 24 2022, 10:38 AM
Reviewer
O1: MITK Reviewer Group I
Differential Revision
Restricted Differential Revision
Parents
rMITK513e872beb07: Replace ViewDirection with AnatomicalPlane
rMITK6cd2ce96452e: Show pixel value for mxnmultiwidget
Branches
Unknown
Tags
Unknown
Tasks
T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations