Page MenuHomePhabricator
Create Task
Maniphest T26543

Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations
Closed, ResolvedPublic
Actions

Description

The different view planes / view modes are used at many different locations. It might make sense to move them to a single specific location to have a consistent naming and to allow the use of this enums as arguments for different functions.

Where such enums are defined:

  • QmitkRenderWindowMenu.h (has been removed in dd6d221ed26b)
  • mitkPlaneGeometry.h
  • QmitkStdMultiWidget.h (has been moved to mitkBaseRenderer.h in a0b88fbab45c)
  • mitkSliceNavigationController.h
  • mitkNavigationDataSliceVisualization.h (kind of)
  • mitkCLUtil.h (kind of)
API breaking changes

Remove the ViewDirection enum from the BaseRenderer
and use the new AnatomicalPlane enum class for the
different directions / planes.
Remove the ViewDirection enum from the SliceNavigationController
and use the new AnatomicalPlane enum class for the
different directions / planes.
Remove the PlaneOrientation enum from the PlaneGeometry
and use the new AnatomicalPlane enum class for the
different orientations / planes.

Migration should be easy, since the different directions / planes /
orientations are the same and in the same order as before.
"ViewDirection::THREE_D" is now "AnatomicalPlane::Original".
"PlaneOrientation::None" is now "AnatomicalPlane::Original".

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITK748b94b4186d Merge enums for view direction
Restricted Differential RevisionrMITK513e872beb07 Replace ViewDirection with AnatomicalPlane
Restricted Differential RevisionrMITKc0f6326f8503 Use anatomical plane in depending classes
Restricted Differential RevisionrMITK4d4c91e4f9b5 Replace ViewDirection and PlaneOrientation with AnatomicalPlane

Related Objects
Search...

Event Timeline

kalali created this task.Jul 31 2019, 7:14 PM
kalali added a comment.EditedAug 1 2019, 11:23 AM

mitkBaseRenderer.h already contains the enum for Standard2D and Standard3D, which is needed if one wants to switch between 2D and 3D view.
The file is part of MITK Core so that could be a good location to put the view direction enum.

kalali moved this task from Backlog to MITK Meeting on the Request for Discussion board.Aug 1 2019, 2:03 PM

This will further allow to remove the string query (e.g. "axial") for render windows but allow a type-based request.

kislinsk triaged this task as Low priority.Aug 2 2019, 11:26 AM
kislinsk added a subscriber: kislinsk.

This is actually a huge topic with many implications. So we will defer the discussion.

kislinsk moved this task from MITK Meeting to Backlog on the Request for Discussion board.Aug 2 2019, 11:26 AM
kalali mentioned this in T24215: Refactor classes to use the QmitkAbstractMultiWidget(Editor).Aug 6 2019, 6:53 PM
kalali mentioned this in T25595: [Multi widget] Make classes work with the new render window access.Aug 7 2019, 9:56 AM
kislinsk closed this task as Wontfix.Oct 14 2021, 11:38 AM

Hi there! 🙂

This task was auto-closed according to our Task Lifecycle Management.
Please follow this link for more information and don't forget that you are encouraged to reasonable re-open tasks to revive them. 🚑

Best wishes,
The MITK devs

kalali reopened this task as Open.Jun 2 2022, 12:26 PM
kalali moved this task from Backlog to MITK Meeting on the Request for Discussion board.
kalali added a parent task: T25595: [Multi widget] Make classes work with the new render window access.Jun 2 2022, 12:34 PM
kalali closed subtask T29207: Remove "Frontal" and "Transversal" as view direction from the code base as Resolved.Jun 29 2022, 9:58 AM
kalali removed a parent task: T25595: [Multi widget] Make classes work with the new render window access.Oct 14 2022, 1:10 PM
kalali mentioned this in T29364: [mxn multi widget] Image navigator cannot be used.Oct 17 2022, 4:29 PM
kalali added a comment.Nov 8 2022, 12:47 PM

It seems as if there is a mapping between the SliceNavigationController::ViewDirection and PlaneGeometry::PlaneOrientation, which makes it unnecessary to keep the direction / orientation in both classes.

I created a first differential for this task removing the SliceNavigationController::ViewDirection` as a first step.

kalali claimed this task.Nov 8 2022, 12:48 PM
kalali added a revision: Restricted Differential Revision.
kalali updated the task description. (Show Details)Nov 9 2022, 9:36 AM
kalali raised the priority of this task from Low to Normal.Nov 18 2022, 12:32 PM
floca added a project: Noteworthy.Nov 19 2022, 8:11 PM
floca added a subscriber: floca.

@kalali please indicate that it has breaking changes in your commit message and how to handle them/migrate. thanks.

kalali edited projects, added Breaking Change; removed Request for Discussion.Nov 21 2022, 4:48 PM
In T26543#243885, @floca wrote:

@kalali please indicate that it has breaking changes in your commit message and how to handle them/migrate. thanks.

Yes I will indicate this accordingly.

kalali updated the task description. (Show Details)Nov 23 2022, 5:45 PM
kalali added a commit: rMITK4d4c91e4f9b5: Replace ViewDirection and PlaneOrientation with AnatomicalPlane.Nov 24 2022, 10:38 AM
kalali added a commit: rMITKc0f6326f8503: Use anatomical plane in depending classes.
kalali added a commit: rMITK513e872beb07: Replace ViewDirection with AnatomicalPlane.
kalali added a commit: rMITK748b94b4186d: Merge enums for view direction.
kalali closed this task as Resolved.Nov 24 2022, 10:43 AM
kalali removed a subtask: T29210: Clarify / remove axis-labeling for anatomical planes.
kislinsk mentioned this in T29488: 2023 Week 11 (Mid March).Mar 16 2023, 6:45 AM
MITK · MIC · IMSY · DKFZ