Diffusion MITK 78c7dc4a6bd9

Merge branch 'bugfix/T29546-FixVariousCrashes' into develop
Concern Raised78c7dc4a6bd9
Actions

Tags

None

Referenced Files

None

Subscribers

Description

Merge branch 'bugfix/T29546-FixVariousCrashes' into develop

Details

Auditors

floca
kislinsk

Provenance

kislinsk	Authored on Apr 28 2023, 3:19 PM
kislinsk	Pushed on Apr 28 2023, 3:19 PM

Parents

rMITKbb5943b91ca7: Improve code formatting
rMITK5b0c1ae43f3d: Total Segmentator tool: support for all subtasks

Branches

Unknown

Tags

Unknown

Event Timeline

kislinsk committed rMITK78c7dc4a6bd9: Merge branch 'bugfix/T29546-FixVariousCrashes' into develop (authored by kislinsk).Apr 28 2023, 3:19 PM

floca raised a concern with this commit.Apr 28 2023, 6:12 PM

floca added a subscriber: floca.

floca added inline comments.

/Modules/SegmentationUI/Qmitk/QmitkMultiLabelInspector.cpp
615–623	first of all thanks for fixing so many problems! Damn it is **** that we missed them so far. To that code: Why are you bound the action to remove a group to the fact that there is a label? I would anderstand if you check that there is more than one group.

This commit now has outstanding concerns.Apr 28 2023, 6:12 PM

kislinsk added inline comments.Apr 28 2023, 7:29 PM

/Modules/SegmentationUI/Qmitk/QmitkMultiLabelInspector.cpp
615–623	That was the intent. I copied it from another location where I thought the next group is searched as well but I guess I misinterpreted it. Is there already a method for counting groups or getting the next group?

kislinsk accepted this commit.Apr 28 2023, 7:59 PM

kislinsk marked an inline comment as done.

kislinsk added inline comments.

/Modules/SegmentationUI/Qmitk/QmitkMultiLabelInspector.cpp
615–623	See D811.

kislinsk mentioned this in T29565: 2023 Week 18 (Very Early May).May 4 2023, 3:02 PM

Merged Changes

bb5943b91ca7 Improve code formatting
Author
kislinsk
Browse Repository
No Builds
No Audits
81c87e38b615 Change format of instance number
Author
kislinsk
Browse Repository
No Builds
No Audits
c5c6acda66c1 Prevent deletion of last remaining group
Author
kislinsk
Browse Repository
No Builds
No Audits
cde38ae72c5d Fix method name type
Author
kislinsk
Browse Repository
No Builds
No Audits
28b42fe4bdba Fix out of bounds crash
Author
kislinsk
Browse Repository
No Builds
No Audits
f57968c21ed1 Clean up documentation
Author
kislinsk
Browse Repository
No Builds
No Audits
4381d9427fe0 Set name and color of new label
Author
kislinsk
Browse Repository
No Builds
No Audits

Changes (9)

Path

Size

Packages

Modules/

Multilabel/

mitkDICOMSegmentationPropertyHelper.cpp

O1: MITK Reviewer Group I

mitkLabelSetImage.cpp

O1: MITK Reviewer Group I

mitkLabelSetImage.h

O1: MITK Reviewer Group I

SegmentationUI/

Qmitk/

QmitkMultiLabelInspector.cpp

O1: MITK Reviewer Group I

QmitkMultiLabelManager.cpp

O1: MITK Reviewer Group I

QmitkMultiLabelTreeModel.cpp

O1: MITK Reviewer Group I

Plugins/

org.mitk.gui.qt.segmentation/

src/

QmitkNewSegmentationDialog.cpp

O1: MITK Reviewer Group I

QmitkNewSegmentationDialog.h

O1: MITK Reviewer Group I

internal/

QmitkSegmentationView.cpp

O1: MITK Reviewer Group I

rMITK78c7dc4a6bd9

Modules/Multilabel/mitkDICOMSegmentationPropertyHelper.cpp

Loading...

Modules/Multilabel/mitkLabelSetImage.cpp

Loading...

Modules/Multilabel/mitkLabelSetImage.h

Loading...

Modules/SegmentationUI/Qmitk/QmitkMultiLabelInspector.cpp

Loading...

Modules/SegmentationUI/Qmitk/QmitkMultiLabelManager.cpp

Loading...

Modules/SegmentationUI/Qmitk/QmitkMultiLabelTreeModel.cpp

Loading...

Plugins/org.mitk.gui.qt.segmentation/src/QmitkNewSegmentationDialog.cpp

Loading...

Plugins/org.mitk.gui.qt.segmentation/src/QmitkNewSegmentationDialog.h

Loading...

Plugins/org.mitk.gui.qt.segmentation/src/internal/QmitkSegmentationView.cpp

Loading...