Diffusion MITK 936b789bbc0a

Refactor DeformableClippingPlane plugin to use the new node selection widgets
936b789bbc0a
Actions

Description

Refactor DeformableClippingPlane plugin to use the new node selection widgets

Summary:
Clean class: reorder functions, fix style, remove comments

Use new Qt5 signal-slot syntax

Clean code: use auto, define node predicates

Modify UI to include single node selection widget

Test Plan: manual

Reviewers: floca, O1 MITK Reviewer Group I, kislinsk

Reviewed By: O1 MITK Reviewer Group I, kislinsk

Subscribers: kislinsk, floca, kalali

Maniphest Tasks: T27595

Differential Revision: https://phabricator.mitk.org/D365

Details

Provenance

kalali	Authored on Aug 2 2020, 11:34 AM
kalali	Pushed on Aug 3 2020, 1:11 PM

Reviewer

O1: MITK Reviewer Group I

Differential Revision

Restricted Differential Revision

Parents

rMITK540a9ae22d0d: Ensure color components to be <= 1.0f
rMITK899caed2f76e: Merge branch 'hotfix/T25882-CDash-v2.6' into develop

Branches

Unknown

Tags

Unknown

Tasks

T27595: Refactor DeformableClippingPlane plugin to use the new node selection widgets

Event Timeline

kalali committed rMITK936b789bbc0a: Refactor DeformableClippingPlane plugin to use the new node selection widgets (authored by kalali).Aug 3 2020, 1:12 PM

kalali added an edge: Restricted Differential Revision.

kalali added a task: T27595: Refactor DeformableClippingPlane plugin to use the new node selection widgets.

kislinsk mentioned this in T27695: 2020 Week 36 (Very Early September).Sep 1 2020, 3:34 PM

Merged Changes

540a9ae22d0d Ensure color components to be <= 1.0f
Author
kalali
Browse Repository
No Builds
No Audits
3accc287f87d Add more const-correctness
Author
kalali
Browse Repository
No Builds
No Audits
0b78143eecdf Simplify function and make it more readable
Author
kalali
Browse Repository
No Builds
No Audits
d074f7074a76 Simplify condition to enable UI element (group box)
Author
kalali
Browse Repository
No Builds
No Audits
52360025467c Simplify for-loop and change style
Author
kalali
Browse Repository
No Builds
No Audits
9443f151d240 Make nullptr check more visible
Author
kalali
Browse Repository
No Builds
No Audits
c63c38d0ab16 Use auto
Author
kalali
Browse Repository
No Builds
No Audits
41eed2598243 Fix missing "this" pointer
Author
kalali
Browse Repository
No Builds
No Audits
27164bacf476 Simplify string comparison
Author
kalali
Browse Repository
No Builds
No Audits
13e2b28d1f68 Use mitk numeric constant
Author
kalali
Browse Repository
No Builds
No Audits
130dcde2604e Move controls initialization to constructor initializer list
Author
kalali
Browse Repository
No Builds
No Audits
1a203b8744af Use const ref value for the list of nodes
Author
kalali
Browse Repository
No Builds
No Audits
c0bab37190df Change include type
Author
kalali
Browse Repository
No Builds
No Audits
360cbd97d8b1 Use explicit type
Author
kalali
Browse Repository
No Builds
No Audits
d8fab84f37d5 Use const iterator
Author
kalali
Browse Repository
No Builds
No Audits
a46a421d410e Fix unused parameter
Author
kalali
Browse Repository
No Builds
No Audits
7b75d1810240 Fix error with hidden virtual function
Author
kalali
Browse Repository
No Builds
No Audits
fc60fc85e4b0 Modify UI to include single node selection widget
Author
kalali
Browse Repository
No Builds
No Audits
fc88c26aa74c Clean code: use auto, define node predicates
Author
kalali
Browse Repository
No Builds
No Audits
85bd2c3a02e7 Use new Qt5 signal-slot syntax
Author
kalali
Browse Repository
No Builds
No Audits
a67b507f168c Clean class: reorder functions, fix style, remove comments
Author
kalali
Browse Repository
No Builds
No Audits

Changes (3)

Path

Size

Packages

Plugins/

org.mitk.gui.qt.segmentation/

src/

internal/

QmitkDeformableClippingPlaneView.cpp

O1: MITK Reviewer Group I

QmitkDeformableClippingPlaneView.h

O1: MITK Reviewer Group I

QmitkDeformableClippingPlaneViewControls.ui

O1: MITK Reviewer Group I

rMITK936b789bbc0a

View Options

Plugins/org.mitk.gui.qt.segmentation/src/internal/QmitkDeformableClippingPlaneView.cpp

View Options

Plugins/org.mitk.gui.qt.segmentation/src/internal/QmitkDeformableClippingPlaneView.h

View Options

Plugins/org.mitk.gui.qt.segmentation/src/internal/QmitkDeformableClippingPlaneViewControls.ui

Refactor DeformableClippingPlane plugin to use the new node selection widgets936b789bbc0aActions

Description

Details

Event Timeline

Merged Changes

Changes (3)

rMITK936b789bbc0a

Plugins/org.mitk.gui.qt.segmentation/src/internal/QmitkDeformableClippingPlaneView.cpp

Plugins/org.mitk.gui.qt.segmentation/src/internal/QmitkDeformableClippingPlaneView.h

Plugins/org.mitk.gui.qt.segmentation/src/internal/QmitkDeformableClippingPlaneViewControls.ui

Refactor DeformableClippingPlane plugin to use the new node selection widgets
936b789bbc0a
Actions