HomePhabricator
Diffusion MITK ca33f3910d98

Switch new dicom node naming to patientID-Modality
Concern Raisedca33f3910d98

This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Switch new dicom node naming to patientID-Modality

Details

Auditors
floca
Provenance
gochAuthored on Sep 6 2017, 5:49 PM
gochPushed on Sep 6 2017, 5:49 PM

Event Timeline

floca raised a concern with this commit.Nov 23 2017, 3:58 PM
floca added a subscriber: floca.
floca added inline comments.
/Plugins/org.mitk.gui.qt.dicom/src/internal/DicomEventHandler.cpp
350–351

I would propose to use the DICOMTagPath and PropertyKey generation helpers instead of "magic number" strings!

This commit now has outstanding concerns.Nov 23 2017, 3:58 PM
/Plugins/org.mitk.gui.qt.dicom/src/internal/DicomEventHandler.cpp
333–351

I am a bit sceptical to change naming this way. This will also often bring name collisions. Every MRI of a single patient will be named equaly!!!
I think this will drive a lot of users mad, escpecially because it is more likely that they have a multi-modal/multi-parametric scenario then a multi-subject scenario in the workbench.

I definetly would keep at least the series desciption or use all 4.

I think at the end (but not as a hard requirement) it would be best, that we allow the configuration of the node naming patterns. E.g. a mircoservice were you can register for different data types which name template and property keys should be used to generate a concrete name.

As an addition to my last review comment. I just stumpled upon a task that already described what I meant (totally forgot about it).

T19477: Select which dicom tags are used to create a nodes name

Commit No Longer Exists

This commit no longer exists in the repository.