Paths

Table of Contentst

Diffusion MITK db065cd38360

Fix comments, refactor, clean code
db065cd38360
Actions

Description

Fix comments, refactor, clean code

Summary:
Integrated old branch into develop with latest changes of the plugin.
Main refactoring affects

new Qt signal-slot syntax
removing / rearranging includes
including QmitkDataStorageListInspector and QmitkDataStorageTreeInspector in QmitkDataStorageViewerTestView
fixing comments

Merge remote-tracking branch 'origin/T25753-Refactor-selection-concept-classes' into T25753-Develop-integration

Test Plan: manual GUI test

Reviewers: floca, O1 MITK Reviewer Group I, O3 MITK Reviewer Group II

Reviewed By: floca, O1 MITK Reviewer Group I, O3 MITK Reviewer Group II

Subscribers: floca, kalali

Maniphest Tasks: T25753

Differential Revision: https://phabricator.mitk.org/D326

Details

Provenance

kalali	Authored on Jun 18 2020, 2:37 PM
kalali	Pushed on Jun 23 2020, 1:11 PM

Reviewer

O1: MITK Reviewer Group I

Differential Revision

Restricted Differential Revision

Parents

rMITKb2582322ba49: Merge remote-tracking branch 'origin/T25753-Refactor-selection-concept-classes'…
rMITK119dbc557eb9: Unsupported/untested qt version is now a warning, not a cmake error

Branches

Unknown

Tags

Unknown

Tasks

T25753: Some refactoring of the selection classes

Event Timeline

kalali committed rMITKdb065cd38360: Fix comments, refactor, clean code (authored by kalali).Jun 23 2020, 1:11 PM

kalali added an edge: Restricted Differential Revision.

kalali added a task: T25753: Some refactoring of the selection classes.

kislinsk mentioned this in T27526: 2020 Week 27.Jul 5 2020, 8:11 AM

Merged Changes

b2582322ba49 Merge remote-tracking branch 'origin/T25753-Refactor-selection-concept-classes'…
Author
kalali
Browse Repository
No Builds
No Audits
afcc73444f66 Refactor; clean code
Author
kalali
Browse Repository
No Builds
No Audits
5ac58b039049 Fix comments, refactor, clean code
Author
kalali
Browse Repository
No Builds
No Audits

Changes (18)

Path

Size

Packages

Modules/

QtWidgets/

include/

QmitkAbstractNodeSelectionWidget.h

O3: MITK Reviewer Group II

QmitkDataStorageSimpleTreeModel.h

O3: MITK Reviewer Group II

src/

QmitkAbstractNodeSelectionWidget.cpp

O3: MITK Reviewer Group II

QmitkDataStorageDefaultListModel.cpp

O3: MITK Reviewer Group II

QmitkDataStorageListModel.cpp

O3: MITK Reviewer Group II

QmitkDataStorageSimpleTreeModel.cpp

O3: MITK Reviewer Group II

Plugins/

org.mitk.gui.qt.common/

src/

QmitkMultiNodeSelectionWidget.cpp

O1: MITK Reviewer Group I

QmitkMultiNodeSelectionWidget.h

O1: MITK Reviewer Group I

QmitkNodeSelectionButton.cpp

O1: MITK Reviewer Group I

QmitkNodeSelectionButton.h

O1: MITK Reviewer Group I

QmitkNodeSelectionDialog.cpp

O1: MITK Reviewer Group I

QmitkNodeSelectionDialog.h

O1: MITK Reviewer Group I

QmitkSelectionServiceConnector.h

O1: MITK Reviewer Group I

QmitkSingleNodeSelectionWidget.cpp

O1: MITK Reviewer Group I

QmitkSingleNodeSelectionWidget.h

O1: MITK Reviewer Group I

org.mitk.gui.qt.datastorageviewertest/

src/

internal/

QmitkDataStorageViewerTestControls.ui

QmitkDataStorageViewerTestView.cpp

QmitkDataStorageViewerTestView.h

rMITKdb065cd38360

View Options

Modules/QtWidgets/include/QmitkAbstractNodeSelectionWidget.h

View Options

Modules/QtWidgets/include/QmitkDataStorageSimpleTreeModel.h

View Options

Modules/QtWidgets/src/QmitkAbstractNodeSelectionWidget.cpp

View Options

Modules/QtWidgets/src/QmitkDataStorageDefaultListModel.cpp

View Options

Modules/QtWidgets/src/QmitkDataStorageListModel.cpp

View Options

Modules/QtWidgets/src/QmitkDataStorageSimpleTreeModel.cpp

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkMultiNodeSelectionWidget.cpp

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkMultiNodeSelectionWidget.h

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionButton.cpp

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionButton.h

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionDialog.cpp

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionDialog.h

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkSelectionServiceConnector.h

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkSingleNodeSelectionWidget.cpp

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkSingleNodeSelectionWidget.h

View Options

Plugins/org.mitk.gui.qt.datastorageviewertest/src/internal/QmitkDataStorageViewerTestControls.ui

View Options

Plugins/org.mitk.gui.qt.datastorageviewertest/src/internal/QmitkDataStorageViewerTestView.cpp

View Options

Plugins/org.mitk.gui.qt.datastorageviewertest/src/internal/QmitkDataStorageViewerTestView.h

Fix comments, refactor, clean codedb065cd38360Actions

Description

Details

Event Timeline

Merged Changes

Changes (18)

rMITKdb065cd38360

Modules/QtWidgets/include/QmitkAbstractNodeSelectionWidget.h

Modules/QtWidgets/include/QmitkDataStorageSimpleTreeModel.h

Modules/QtWidgets/src/QmitkAbstractNodeSelectionWidget.cpp

Modules/QtWidgets/src/QmitkDataStorageDefaultListModel.cpp

Modules/QtWidgets/src/QmitkDataStorageListModel.cpp

Modules/QtWidgets/src/QmitkDataStorageSimpleTreeModel.cpp

Plugins/org.mitk.gui.qt.common/src/QmitkMultiNodeSelectionWidget.cpp

Plugins/org.mitk.gui.qt.common/src/QmitkMultiNodeSelectionWidget.h

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionButton.cpp

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionButton.h

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionDialog.cpp

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionDialog.h

Plugins/org.mitk.gui.qt.common/src/QmitkSelectionServiceConnector.h

Plugins/org.mitk.gui.qt.common/src/QmitkSingleNodeSelectionWidget.cpp

Plugins/org.mitk.gui.qt.common/src/QmitkSingleNodeSelectionWidget.h

Plugins/org.mitk.gui.qt.datastorageviewertest/src/internal/QmitkDataStorageViewerTestControls.ui

Plugins/org.mitk.gui.qt.datastorageviewertest/src/internal/QmitkDataStorageViewerTestView.cpp

Plugins/org.mitk.gui.qt.datastorageviewertest/src/internal/QmitkDataStorageViewerTestView.h

Fix comments, refactor, clean code
db065cd38360
Actions