Diffusion MITK e960930c4c36

LiveWire tool issues and improvements
e960930c4c36
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

LiveWire tool issues and improvements

Summary:
Solves T28607
Increase "hit box" for contour points.
Add segment that visually connects the current mouse position with the contour start point with a straight line.
Always close the contour on double click , not just if start point is clicked.

Test Plan: manual

Reviewers: O1 MITK Reviewer Group I, floca, O3 MITK Reviewer Group II

Reviewed By: O1 MITK Reviewer Group I, floca, O3 MITK Reviewer Group II

Subscribers: kahl, floca

Maniphest Tasks: T28607

Differential Revision: https://phabricator.mitk.org/D522

Details

Provenance

kahl	Authored on Oct 18 2021, 8:45 AM
• kleina	Committed on Oct 18 2021, 9:47 AM
• kleina	Pushed on Oct 18 2021, 9:47 AM

Reviewer

O1: MITK Reviewer Group I

Differential Revision

Restricted Differential Revision

Parents

rMITK272b664745e2: Merge branch 'bugfix/T28749-libxdamage' into develop
rMITK85e2645d4d9b: refactorings from review

Branches

Unknown

Tags

Unknown

Tasks

T28607: [Segmentation] LiveWire tool issues and improvements

Event Timeline

André Klein <kleina@ad.dkfz-heidelberg.de> committed rMITKe960930c4c36: LiveWire tool issues and improvements (authored by kahl).Oct 18 2021, 9:47 AM

André Klein <kleina@ad.dkfz-heidelberg.de> added a task: T28607: [Segmentation] LiveWire tool issues and improvements.

André Klein <kleina@ad.dkfz-heidelberg.de> added an edge: Restricted Differential Revision.

kislinsk mentioned this in T28802: 2021 Week 45 (Early November).Oct 29 2021, 4:11 PM

Merged Changes

85e2645d4d9b refactorings from review
Author
kahl
Browse Repository
No Builds
No Audits
41981c2e30b1 Merge branch 'develop' into feature/T28607-live-wire-improvements
Author
kahl
Browse Repository
No Builds
No Audits
4bb9a540550f fix initialization and return statement in itkShortestPathImageFilter
Author
kahl
Browse Repository
No Builds
No Audits
2809ba702298 removed unused variables
Author
kahl
Browse Repository
No Builds
No Audits
c2a28ece5d32 deleted old implementation of SplitContourFromSelectedVertex and added comments
Author
kahl
Browse Repository
No Builds
No Audits
010f7051103f implement edge cases for moving points
Author
kahl
Browse Repository
No Builds
No Audits
699f9b84b3d3 refactor get vertex and split contour
Author
kahl
Browse Repository
No Builds
No Audits
bc4a6076f49a avoid vertex to be added outside contour
Author
kahl
Browse Repository
No Builds
No Audits
2a67f8b6662b Updated comments
Author
• kleina
Browse Repository
No Builds
No Audits
131b13111f16 Changed mitk::ContourElement::BruteForceGetVertexAt
Author
• kleina
Browse Repository
No Builds
No Audits
6532dcd5d797 Added filter to closure contour.
Author
• kleina
Browse Repository
No Builds
No Audits
601626d86db9 Structured selection of vertex on click.
Author
• kleina
Browse Repository
No Builds
No Audits
b77ed99edd1e Quick and dirty version to disable cost fucntion.
Author
• kleina
Browse Repository
No Builds
No Audits
2754c6f69089 Added method to get control vertex.
Author
• kleina
Browse Repository
No Builds
No Audits
2961a363ab60 Add constant for vertex eps.
Author
• kleina
Browse Repository
No Builds
No Audits
6da0cebf157f Check plane geometry during drawing of contours to make sure
Author
• kleina
Browse Repository
No Builds
No Audits
f5e005e0f53b renamed contour
Author
• kleina
Browse Repository
No Builds
No Audits
c0e8a4f6930d Always close the contour on double click , not just if start point is clicked.
Author
• kleina
Browse Repository
No Builds
No Audits
70c956ac9b1f Add segment that visually connects the current mouse position with the contour…
Author
• kleina
Browse Repository
No Builds
No Audits
f00e1392bc00 Increase "hit box" for contour points.
Author
• kleina
Browse Repository
No Builds
No Audits

Changes (12)

Path

Size

Packages

Modules/

ContourModel/

DataManagement/

mitkContourElement.cpp

O3: MITK Reviewer Group II

mitkContourElement.h

O3: MITK Reviewer Group II

mitkContourModel.cpp

O3: MITK Reviewer Group II

mitkContourModel.h

O3: MITK Reviewer Group II

GraphAlgorithms/

itkShortestPathImageFilter.h

itkShortestPathImageFilter.txx

Segmentation/

Algorithms/

mitkImageLiveWireContourModelFilter.h

O1: MITK Reviewer Group I

Interactions/

mitkContourModelLiveWireInteractor.cpp

O1: MITK Reviewer Group I

mitkContourModelLiveWireInteractor.h

O1: MITK Reviewer Group I

mitkLiveWireTool2D.cpp

O1: MITK Reviewer Group I

mitkLiveWireTool2D.h

O1: MITK Reviewer Group I

Resources/

Interactions/

LiveWireTool.xml

O1: MITK Reviewer Group I

rMITKe960930c4c36

Modules/ContourModel/DataManagement/mitkContourElement.cpp

Loading...

Modules/ContourModel/DataManagement/mitkContourElement.h

Loading...

Modules/ContourModel/DataManagement/mitkContourModel.cpp

Loading...

Modules/ContourModel/DataManagement/mitkContourModel.h

Loading...

Modules/GraphAlgorithms/itkShortestPathImageFilter.h

Loading...

Modules/GraphAlgorithms/itkShortestPathImageFilter.txx

Loading...

Modules/Segmentation/Algorithms/mitkImageLiveWireContourModelFilter.h

Loading...

Modules/Segmentation/Interactions/mitkContourModelLiveWireInteractor.cpp

Loading...

Modules/Segmentation/Interactions/mitkContourModelLiveWireInteractor.h

Loading...

Modules/Segmentation/Interactions/mitkLiveWireTool2D.cpp

Loading...

Modules/Segmentation/Interactions/mitkLiveWireTool2D.h

Loading...

Modules/Segmentation/Resources/Interactions/LiveWireTool.xml

Loading...