Page MenuHomePhabricator

kahl (Kim-Celine Kahl)
User

Projects

User Details

User Since
Oct 13 2017, 9:09 AM (240 w, 3 d)

Recent Activity

Mar 29 2022

kahl added a comment to T28607: [Segmentation] LiveWire tool issues and improvements.

Regarding the comment of closing the contour with a double click: I also realized this during my work on the new add tool and I think the way I fixed it was to modify the OnFinish() function in the mitkLiveWireTool2D to check whether the click was performed on the first point which was also how it was done before the closure contour was added to the LiveWire tool.
Here is the code of my new add tool branch where I changed it:
https://phabricator.mitk.org/source/mitk/browse/feature%252FT28464-new-add-tool-2/Modules/Segmentation/Interactions/mitkLiveWireTool2D.cpp$344

Mar 29 2022, 9:35 AM · MITK (v2022.10), Cleared, Checklist

Mar 8 2022

kahl added a comment to T28464: [Segmentation] New Add/Remove tool.

Pushed new branch to rMITK MITK: feature/T28464-new-add-tool-2.

Mar 8 2022, 12:06 PM · MITK (v2022.10)

Feb 16 2022

kahl committed rMITKe4b1887ad0ce: Implement closing contour by two vertices not using filter (authored by kahl).
Implement closing contour by two vertices not using filter
Feb 16 2022, 8:16 AM
kahl committed rMITKe737998ad7d3: Implement toggle between straigt and snapping closure contour (authored by kahl).
Implement toggle between straigt and snapping closure contour
Feb 16 2022, 8:16 AM
kahl committed rMITKe4a66e79d1f8: Change initialization order of m_SnapClosureContour and… (authored by kahl).
Change initialization order of m_SnapClosureContour and…
Feb 16 2022, 8:16 AM
kahl committed rMITK3e6812eecbf1: Directly update closure contour when toggled (authored by kahl).
Directly update closure contour when toggled
Feb 16 2022, 8:16 AM
kahl committed rMITKc1574c85f93d: Remove shortcut for closing contour and adapt label in GUI (authored by kahl).
Remove shortcut for closing contour and adapt label in GUI
Feb 16 2022, 8:16 AM
kahl committed rMITK82cd2c7aa88b: Fix nullpointer exception (authored by kahl).
Fix nullpointer exception
Feb 16 2022, 8:16 AM
kahl closed T28959: [Segmentation] LiveWire Closing Contour improvements as Resolved by committing rMITK7872f0ef38c7: LiveWire Closing Contour improvements.
Feb 16 2022, 8:16 AM · MITK
kahl committed rMITK7872f0ef38c7: LiveWire Closing Contour improvements (authored by kahl).
LiveWire Closing Contour improvements
Feb 16 2022, 8:16 AM

Feb 14 2022

kahl placed T28778: "Use constraint zooming and panning" is only applied after reinit/restart up for grabs.

No I am not actively working on this issue. I proposed a change but as written in the comments, this broke some rendering test.
We did not investigate closer why this happened. So I reverted the change and currently the initial task is still not fixed.

Feb 14 2022, 10:25 AM · MITK (v2022.10), Checklist

Feb 4 2022

kahl added a revision to T28959: [Segmentation] LiveWire Closing Contour improvements: Unknown Object (Differential Revision).
Feb 4 2022, 10:41 AM · MITK

Feb 2 2022

kahl added a comment to T28959: [Segmentation] LiveWire Closing Contour improvements.

Pushed new branch to rMITK MITK: feature/T28959-livewire-closure-improvements.

Feb 2 2022, 8:51 AM · MITK

Feb 1 2022

kahl triaged T28959: [Segmentation] LiveWire Closing Contour improvements as Normal priority.
Feb 1 2022, 4:12 PM · MITK

Jan 17 2022

kahl removed a project from T28748: [Segmentation] New Add tool: Behavior for modifying painted regions: Request for Discussion.
Jan 17 2022, 8:17 AM · MITK

Nov 30 2021

kahl committed rMITKf68ef917dff3: Fix volume rendering for 4d images, adapt histogram and volume itself (authored by kahl).
Fix volume rendering for 4d images, adapt histogram and volume itself
Nov 30 2021, 3:23 PM
kahl committed rMITKed883fa6af57: Refactorings from review (authored by kahl).
Refactorings from review
Nov 30 2021, 3:23 PM
kahl closed T24754: Volume Visualization crashes with some CT images as Resolved by committing rMITKfd647480c6ec: Fix volume rendering for 4d images.
Nov 30 2021, 3:23 PM · Restricted Project, MITK
kahl closed T28274: [Volume Visualization] Volume Rendering for 4D images does only work on timestep 0 or not at all as Resolved by committing rMITKfd647480c6ec: Fix volume rendering for 4d images.
Nov 30 2021, 3:23 PM · Restricted Project, MITK (v2022.04), Request for Discussion
kahl committed rMITKfd647480c6ec: Fix volume rendering for 4d images (authored by kahl).
Fix volume rendering for 4d images
Nov 30 2021, 3:23 PM

Nov 24 2021

kahl added a revision to T24754: Volume Visualization crashes with some CT images: Unknown Object (Differential Revision).
Nov 24 2021, 1:49 PM · Restricted Project, MITK
kahl added a revision to T28274: [Volume Visualization] Volume Rendering for 4D images does only work on timestep 0 or not at all: Unknown Object (Differential Revision).
Nov 24 2021, 1:49 PM · Restricted Project, MITK (v2022.04), Request for Discussion
kahl added a comment to T28274: [Volume Visualization] Volume Rendering for 4D images does only work on timestep 0 or not at all.

I implemented a fix which includes your suggestion to extend the interfaces of the TranferFunctionWidget and QmitkTransferFunctionGeneratorWidget @floca. This resolves the issue that the histogram is not updated. Additionally, to also update the volume that is shown in the 3D render window, I extended the mitkVolumeMapperVtkSmart3D to also work with the correct timesteps. Before this change, only a volume for timestep 0 was created. With this fix, the workbench also does not crash with the Heart3D+t dataset.

Nov 24 2021, 1:37 PM · Restricted Project, MITK (v2022.04), Request for Discussion
kahl added a comment to T28274: [Volume Visualization] Volume Rendering for 4D images does only work on timestep 0 or not at all.

Pushed new branch to rMITK MITK: bugfix/T28274-volumerendering-multiple-timesteps.

Nov 24 2021, 1:27 PM · Restricted Project, MITK (v2022.04), Request for Discussion

Nov 22 2021

kahl claimed T28274: [Volume Visualization] Volume Rendering for 4D images does only work on timestep 0 or not at all.

I tried to reproduce this bug and for US4DCyl the behaviour was the same when I tested it (histogram remains the same for all timesteps). For Heart3D+t sometimes nothing is displayed at all (as described here) but also sometimes the workbench crashes as described in T24754. However, I could not find any pattern when which behaviour occurs. I tested it with the current release installer on Windows and on the current develop branch in Debug mode. I can try to narrow it down a bit.

Nov 22 2021, 9:09 AM · Restricted Project, MITK (v2022.04), Request for Discussion

Nov 18 2021

kahl added a comment to T28778: "Use constraint zooming and panning" is only applied after reinit/restart.

Pushed new branch to rMITK MITK: bugfix/T28778-fix-rendering-tests.

Nov 18 2021, 10:40 AM · MITK (v2022.10), Checklist

Nov 16 2021

kahl committed rMITKde10d7d801c5: Apply correct zooming and panning when updating render window (authored by kahl).
Apply correct zooming and panning when updating render window
Nov 16 2021, 2:18 PM
kahl committed rMITK86a676bab050: Not set parameter for constraint zooming and panning in InitializeViews (authored by kahl).
Not set parameter for constraint zooming and panning in InitializeViews
Nov 16 2021, 2:18 PM
kahl committed rMITK0dd13925b2cb: Retrive base renderer only once (authored by kahl).
Retrive base renderer only once
Nov 16 2021, 2:18 PM
kahl closed T28778: "Use constraint zooming and panning" is only applied after reinit/restart as Resolved by committing rMITK5b54b904a6fe: Directly apply changes in preferences to "use constraint zooming and panning".
Nov 16 2021, 2:18 PM · MITK (v2022.10), Checklist
kahl committed rMITK5b54b904a6fe: Directly apply changes in preferences to "use constraint zooming and panning" (authored by kahl).
Directly apply changes in preferences to "use constraint zooming and panning"
Nov 16 2021, 2:18 PM

Nov 15 2021

kahl added a revision to T28778: "Use constraint zooming and panning" is only applied after reinit/restart: Unknown Object (Differential Revision).
Nov 15 2021, 9:23 AM · MITK (v2022.10), Checklist
kahl added a comment to T28778: "Use constraint zooming and panning" is only applied after reinit/restart.

Pushed new branch to rMITK MITK: bugfix/T28778-apply-constraint-zooming-panning.

Nov 15 2021, 9:15 AM · MITK (v2022.10), Checklist
kahl claimed T28778: "Use constraint zooming and panning" is only applied after reinit/restart.
Nov 15 2021, 9:04 AM · MITK (v2022.10), Checklist

Nov 4 2021

kahl added a revision to T28795: [Segmentation][Utilities] "Image Masking" has several issues regarding image dimensionality: Unknown Object (Differential Revision).
Nov 4 2021, 3:48 PM · MITK
kahl claimed T28795: [Segmentation][Utilities] "Image Masking" has several issues regarding image dimensionality.
Nov 4 2021, 3:26 PM · MITK
kahl added a comment to T28795: [Segmentation][Utilities] "Image Masking" has several issues regarding image dimensionality.

I also looked into this task yesterday and the issue is that for custom background values, the "AccessByItk_n" function is used, which only works for 2D and 3D images. A potential fix would be to use the "AccessFixedDimensionByItk_n" function for the 4D case, then the Workbench does not crash anymore. So in the QmitkImageMaskingWidget.cpp one could replace

Nov 4 2021, 8:23 AM · MITK

Nov 2 2021

kahl added a comment to T28806: Crash in "Create smooth polygon model" for 2-d images.

After a first look on this problem, I found out that the issue occurs because of the different dimensions between the image and the segmentation. The image is in 2D and the segmentation mask that is created is in 3D.
This can be seen when taking a normal 2D image or when working with Pic2DplusT.nrrd and creating a static segmentation mask. However, when working with Pic2DplusT and creating a dynamic segmentation mask, the Workbench does not crash (because it is 3 dimensional with time again).

Nov 2 2021, 1:20 PM · MITK

Oct 20 2021

kahl added a comment to T28464: [Segmentation] New Add/Remove tool.

Pushed new branch to rMITK MITK: feature/T28464-new-add-tool.

Oct 20 2021, 9:36 AM · MITK (v2022.10)

Oct 18 2021

kahl committed rMITKbc4a6076f49a: avoid vertex to be added outside contour (authored by kahl).
avoid vertex to be added outside contour
Oct 18 2021, 9:48 AM
kahl committed rMITK699f9b84b3d3: refactor get vertex and split contour (authored by kahl).
refactor get vertex and split contour
Oct 18 2021, 9:48 AM
kahl committed rMITK010f7051103f: implement edge cases for moving points (authored by kahl).
implement edge cases for moving points
Oct 18 2021, 9:48 AM
kahl committed rMITK2809ba702298: removed unused variables (authored by kahl).
removed unused variables
Oct 18 2021, 9:48 AM
kahl committed rMITKc2a28ece5d32: deleted old implementation of SplitContourFromSelectedVertex and added comments (authored by kahl).
deleted old implementation of SplitContourFromSelectedVertex and added comments
Oct 18 2021, 9:48 AM
kahl committed rMITK41981c2e30b1: Merge branch 'develop' into feature/T28607-live-wire-improvements (authored by kahl).
Merge branch 'develop' into feature/T28607-live-wire-improvements
Oct 18 2021, 9:48 AM
kahl committed rMITK4bb9a540550f: fix initialization and return statement in itkShortestPathImageFilter (authored by kahl).
fix initialization and return statement in itkShortestPathImageFilter
Oct 18 2021, 9:48 AM
kahl committed rMITK85e2645d4d9b: refactorings from review (authored by kahl).
refactorings from review
Oct 18 2021, 9:48 AM
kahl moved T28748: [Segmentation] New Add tool: Behavior for modifying painted regions from Backlog to MITK Meeting on the Request for Discussion board.
Oct 18 2021, 9:28 AM · MITK
kahl triaged T28748: [Segmentation] New Add tool: Behavior for modifying painted regions as Normal priority.
Oct 18 2021, 9:28 AM · MITK

Sep 30 2021

kahl closed T28521: multilabel segmentation add switch to disable contour as Resolved.
Sep 30 2021, 11:21 AM · MITK (v2021.10)
kahl added a comment to T28521: multilabel segmentation add switch to disable contour.

This function is also available in the preferences (Ctrl+P). There, just select "Draw as transparent overlay" (see image below).

image.png (103×619 px, 5 KB)

Sep 30 2021, 11:21 AM · MITK (v2021.10)

Apr 28 2021

kahl added a comment to T28437: 3D region growing may have issues when the seed point is on a pixel with value 0.

Deleted branch from rMITK MITK: bugfix/T28437-RegionGrowing3DSeedPoint0.

Apr 28 2021, 12:13 PM · MITK (v2021.10)
kahl committed rMITKf0703a7a08e9: modify region growing 3D to work with low seed point value (authored by kahl).
modify region growing 3D to work with low seed point value
Apr 28 2021, 12:06 PM
kahl committed rMITK068b2c265ba8: avoid underflows (authored by kahl).
avoid underflows
Apr 28 2021, 12:06 PM
kahl committed rMITKa3ee5afa1b98: modify region growing 3D to work with low seed point value (authored by kahl).
modify region growing 3D to work with low seed point value
Apr 28 2021, 12:06 PM
kahl closed T28437: 3D region growing may have issues when the seed point is on a pixel with value 0 as Resolved by committing rMITKa3ee5afa1b98: modify region growing 3D to work with low seed point value.
Apr 28 2021, 12:06 PM · MITK (v2021.10)

Apr 23 2021

kahl added a revision to T28437: 3D region growing may have issues when the seed point is on a pixel with value 0: Unknown Object (Differential Revision).
Apr 23 2021, 10:26 AM · MITK (v2021.10)
kahl added a comment to T28437: 3D region growing may have issues when the seed point is on a pixel with value 0.

Pushed new branch to rMITK MITK: bugfix/T28437-RegionGrowing3DSeedPoint0.

Apr 23 2021, 10:02 AM · MITK (v2021.10)

Apr 15 2021

kahl claimed T28437: 3D region growing may have issues when the seed point is on a pixel with value 0.
Apr 15 2021, 10:45 AM · MITK (v2021.10)
kahl moved T28437: 3D region growing may have issues when the seed point is on a pixel with value 0 from Segmentation to Cycle on the MITK (v2021.10) board.
Apr 15 2021, 10:44 AM · MITK (v2021.10)

Jan 27 2021

kahl triaged T28224: [Point Set] List of points is not shown if plugin opened after data loading as Normal priority.
Jan 27 2021, 3:51 PM · MITK (v2021.02)
kahl triaged T28213: [Point Set] Clear current time step does not work as Normal priority.
Jan 27 2021, 1:28 PM · MITK (v2021.02)
kahl triaged T28212: [Point Set] Only points for time step 0 are listed as Normal priority.
Jan 27 2021, 1:20 PM · MITK (v2021.02)

Nov 17 2020

kahl added a comment to T27564: [Segmentation] Integrate deep learning methods for Segmentation in MITK.

Deleted branch feature/T27564-integrate-deeplearning-segmentation-V2.

Nov 17 2020, 10:54 AM · MITK
kahl added a comment to T27564: [Segmentation] Integrate deep learning methods for Segmentation in MITK.

Deleted branch feature/T27564-integrate-deeplearning-segmentation-evaluation.

Nov 17 2020, 10:54 AM · MITK
kahl added a comment to T27564: [Segmentation] Integrate deep learning methods for Segmentation in MITK.

Deleted branch feature/T27564-integrate-deeplearning-segmentation.

Nov 17 2020, 10:54 AM · MITK
kahl added a comment to T27500: Use Python/C-API for execution of Python Code with MITK-Python-Service.

Deleted branch feature/T27500-use-PythonCApi-in-python-service-V2.

Nov 17 2020, 10:54 AM · MITK
kahl added a comment to T27500: Use Python/C-API for execution of Python Code with MITK-Python-Service.

Deleted branch feature/T27500-use-PythonCApi-in-python-service.

Nov 17 2020, 10:54 AM · MITK

Nov 5 2020

kahl closed T27501: Reimplement image transfer between MITK and Python as Resolved.

This task can be closed. Future work on this is done in T27923.

Nov 5 2020, 8:13 AM · MITK
kahl closed T27501: Reimplement image transfer between MITK and Python, a subtask of T27499: Reimplement MITK-Python-Service, as Resolved.
Nov 5 2020, 8:13 AM · MITK
kahl closed T27564: [Segmentation] Integrate deep learning methods for Segmentation in MITK as Resolved.

This task can be closed. Future work on this is done in T27923.

Nov 5 2020, 8:12 AM · MITK
kahl closed T27500: Use Python/C-API for execution of Python Code with MITK-Python-Service, a subtask of T27499: Reimplement MITK-Python-Service, as Resolved.
Nov 5 2020, 8:12 AM · MITK
kahl closed T27500: Use Python/C-API for execution of Python Code with MITK-Python-Service as Resolved.

This task can be closed. Future work on this is done in T27923.

Nov 5 2020, 8:12 AM · MITK
kahl closed T27499: Reimplement MITK-Python-Service as Resolved.

This task can be closed. Future work on this is done in T27923.

Nov 5 2020, 8:11 AM · MITK

Nov 4 2020

kahl added a comment to T27923: Integrate possibility to execute Python Code in MITK .

Pushed new branch feature/T27923-python-dev.

Nov 4 2020, 4:37 PM · MITK

Nov 3 2020

kahl added a comment to T27923: Integrate possibility to execute Python Code in MITK .

Pushed new branch feature/T27923-execute-python-code-in-mitk.

Nov 3 2020, 3:15 PM · MITK
kahl triaged T27923: Integrate possibility to execute Python Code in MITK as Normal priority.
Nov 3 2020, 8:34 AM · MITK

Aug 10 2020

kahl added a comment to T27564: [Segmentation] Integrate deep learning methods for Segmentation in MITK.

Pushed new branch feature/T27564-integrate-deeplearning-segmentation-evaluation.

Aug 10 2020, 5:36 PM · MITK

Jul 31 2020

kahl added a comment to T27500: Use Python/C-API for execution of Python Code with MITK-Python-Service.

Pushed new branch feature/T27500-use-PythonCApi-in-python-service-V2.

Jul 31 2020, 9:58 AM · MITK

Jul 30 2020

kahl placed T27107: [MITKDoc] Revise Screenshot Maker Plugin Documentation up for grabs.
Jul 30 2020, 11:26 AM · Cleared, MITK (v2021.02)
kahl placed T27101: [MITKDoc] Revise Logging Plugin Documentation up for grabs.
Jul 30 2020, 11:25 AM · Cleared, MITK (v2021.02)

Jul 29 2020

kahl added a comment to T27324: Investigate MITK <--> python image transfer.

Seems like I figured it out. What I had to do was to change SWIG_TypeQuery("_p_mitk__Image") to SWIG_TypeQuery("_p_itk__SmartPointerT_mitk__Image_t") and change the type of image to mitk::Image::Pointer *image. When passing Pic3D now and printing the number of dimensions, 3 is printed as one would expect. I will further investigate how to interact with other libraries like SimpleITK.

Jul 29 2020, 4:56 PM · MITK
kahl added a comment to T27324: Investigate MITK <--> python image transfer.

I tried an approach like @floca suggested with the SWIG wrapping that is already available in MITK. Here is my code to transfer a MITK image from C++ to Python:

Jul 29 2020, 3:59 PM · MITK

Jul 28 2020

kahl added a comment to T27600: [SWIG] building pyMITK leads to access violation.

If you use Python 3.7/3.8, you need to install SWIG version 4.0.2. This solves the problem. Currently, SWIG version 3.0.2. is installed in the Superbuild.

Jul 28 2020, 5:17 PM · MITK

Jul 24 2020

kahl triaged T27600: [SWIG] building pyMITK leads to access violation as Normal priority.
Jul 24 2020, 2:11 PM · MITK

Jul 21 2020

kahl added a comment to T27564: [Segmentation] Integrate deep learning methods for Segmentation in MITK.

Pushed new branch feature/T27564-integrate-deeplearning-segmentation-V2.

Jul 21 2020, 1:21 PM · MITK

Jul 16 2020

kahl added a comment to T27564: [Segmentation] Integrate deep learning methods for Segmentation in MITK.

Pushed new branch feature/T27564-integrate-deeplearning-segmentation.

Jul 16 2020, 6:44 PM · MITK
kahl triaged T27564: [Segmentation] Integrate deep learning methods for Segmentation in MITK as Normal priority.
Jul 16 2020, 11:45 AM · MITK

Jul 15 2020

kahl triaged T27561: Clients for building pyMITK Project as Normal priority.
Jul 15 2020, 1:14 PM · Request for Discussion, MITK, CI

Jul 8 2020

kalali awarded T26973: [Segmentation] RegionGrowing3D preview only in 3D Widget a Cup of Joe token.
Jul 8 2020, 12:30 PM · MITK (v2021.02)
kahl added a comment to T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images.

@kalali I can confirm that there is no option to use autocrop when using the ITK NrrdImageIO reader. However, when you load an image with the ITK reader (I used MultiLabel/Pic3DAsMultilabelImage.nrrd as well) and you convert it to a segmentation
(Right click ->Convert to segmentation) and then autocrop the new segmentation node, the name also changes to "No Name". So it might be a general problem when autocropping.

Jul 8 2020, 11:45 AM · Request for Discussion, Missing Info, MITK (v2021.02)
kahl closed T26973: [Segmentation] RegionGrowing3D preview only in 3D Widget as Resolved.

As the bug couldn't be reproduced, it can be closed.

Jul 8 2020, 11:39 AM · MITK (v2021.02)

Jul 6 2020

kahl triaged T27534: Generate batch file for PluginGenerator as Low priority.
Jul 6 2020, 4:04 PM · MITK, Next Milestone

Jul 2 2020

kahl added a comment to T26973: [Segmentation] RegionGrowing3D preview only in 3D Widget.

I couldn't reproduce it myself and to be honest, I don't know which picture I took when the bug occured. @thomass Do you still know more about this bug? I think we encountered it when we were testing with the Checklists.

Jul 2 2020, 4:45 PM · MITK (v2021.02)

Jun 29 2020

kahl added a comment to T27500: Use Python/C-API for execution of Python Code with MITK-Python-Service.

Pushed new branch feature/T27500-use-PythonCApi-in-python-service.

Jun 29 2020, 3:44 PM · MITK

Jun 23 2020

kahl triaged T27501: Reimplement image transfer between MITK and Python as Normal priority.
Jun 23 2020, 5:14 PM · MITK
kahl triaged T27500: Use Python/C-API for execution of Python Code with MITK-Python-Service as Normal priority.
Jun 23 2020, 4:55 PM · MITK
kahl triaged T27499: Reimplement MITK-Python-Service as Normal priority.
Jun 23 2020, 4:44 PM · MITK

Feb 17 2020

kahl committed rMITKe1c1e8aa494b: removed cancel, added option for default network (authored by kahl).
removed cancel, added option for default network
Feb 17 2020, 10:50 AM

Feb 14 2020

kahl committed rMITK9c67bc4b21be: Update logging documentation (authored by kahl).
Update logging documentation
Feb 14 2020, 3:26 PM