Diffusion MITK ef9f6d0e4b97

Reworkd AbstractNodeSelectionWidget and introduced node changed observers
ef9f6d0e4b97
Actions

Description

Reworkd AbstractNodeSelectionWidget and introduced node changed observers

Summary:
Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Started unit test for AbstractNodeSelectionWidget

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Test Plan: unit test and code review

Reviewers: MITK Reviewer Group I, kalali

Reviewed By: kalali

Maniphest Tasks: T27064

Differential Revision: https://phabricator.mitk.org/D250

Details

Provenance

floca	Authored on Feb 28 2020, 1:23 PM
floca	Pushed on Feb 28 2020, 2:48 PM

Reviewer

kalali

Differential Revision

Restricted Differential Revision

Parents

rMITK303ac2bd6b76: Merge branch 'master' into T27064-NodeSelectionWidgets_validate_nodes_on_node_c…
rMITKc9b4d0b96cf0: Merge branch 'T27168-DefaultRangeForSliceAndTimeAnimations'

Branches

Unknown

Tags

Unknown

Tasks

T27064: NodeSelectionWidgets have to listen to changes of nodes and check if there selection is still valid.

Event Timeline

floca committed rMITKef9f6d0e4b97: Reworkd AbstractNodeSelectionWidget and introduced node changed observers (authored by floca).Feb 28 2020, 2:48 PM

floca added a task: T27064: NodeSelectionWidgets have to listen to changes of nodes and check if there selection is still valid..

floca added an edge: Restricted Differential Revision.Apr 30 2020, 11:42 PM

Merged Changes

303ac2bd6b76 Merge branch 'master' into T27064-NodeSelectionWidgets_validate_nodes_on_node_c…
Author
floca
Browse Repository
No Builds
No Audits
50efa3369527 removed redundant test (which caused gcc errors)
Author
floca
Browse Repository
No Builds
No Audits
f2c19c004c19 - Fixed gcc error in test
Author
floca
Browse Repository
No Builds
No Audits
0ecb22879234 Fixed review remarks
Author
floca
Browse Repository
No Builds
No Audits
10e04283429e fixed gcc compile errors
Author
floca
Browse Repository
No Builds
No Audits
d20a08d622f1 Added test for OnNodeModified feature
Author
floca
Browse Repository
No Builds
No Audits
2b4103abfe62 Optimized thumbnail sizeing and positioning
Author
floca
Browse Repository
No Builds
No Audits
3932ce9b8913 Added missing tests.
Author
floca
Browse Repository
No Builds
No Audits
e6f71353bb79 Improved documentation
Author
floca
Browse Repository
No Builds
No Audits
11d9a8b927a2 Started unit test for AbstractNodeSelectionWidget
Author
floca
Browse Repository
No Builds
No Audits
044dc2f2f657 Reworkd AbstractNodeSelectionWidget and introduced node changed observers
Author
floca
Browse Repository
No Builds
No Audits

Changes (15)

Path

Size

Packages

Modules/

QtWidgets/

files.cmake

O3: MITK Reviewer Group II

include/

QmitkAbstractNodeSelectionWidget.h

O3: MITK Reviewer Group II

src/

QmitkAbstractNodeSelectionWidget.cpp

O3: MITK Reviewer Group II

test/

QmitkAbstractNodeSelectionWidgetTest.cpp

O3: MITK Reviewer Group II

files.cmake

O3: MITK Reviewer Group II

Plugins/

org.mitk.gui.qt.common/

files.cmake

O1: MITK Reviewer Group I

src/

QmitkAbstractNodeSelectionWidget.cpp

O1: MITK Reviewer Group I

QmitkAbstractNodeSelectionWidget.h

O1: MITK Reviewer Group I

QmitkMultiNodeSelectionWidget.cpp

O1: MITK Reviewer Group I

QmitkMultiNodeSelectionWidget.h

O1: MITK Reviewer Group I

QmitkNodeSelectionButton.cpp

O1: MITK Reviewer Group I

QmitkNodeSelectionButton.h

O1: MITK Reviewer Group I

QmitkSingleNodeSelectionWidget.cpp

O1: MITK Reviewer Group I

QmitkSingleNodeSelectionWidget.h

O1: MITK Reviewer Group I

org.mitk.gui.qt.datastorageviewertest/

src/

internal/

QmitkDataStorageViewerTestView.cpp

rMITKef9f6d0e4b97

View Options

Modules/QtWidgets/files.cmake

View Options

Modules/QtWidgets/include/QmitkAbstractNodeSelectionWidget.h

View Options

Modules/QtWidgets/src/QmitkAbstractNodeSelectionWidget.cpp

View Options

Modules/QtWidgets/test/QmitkAbstractNodeSelectionWidgetTest.cpp

View Options

Modules/QtWidgets/test/files.cmake

View Options

Plugins/org.mitk.gui.qt.common/files.cmake

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkAbstractNodeSelectionWidget.cpp

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkAbstractNodeSelectionWidget.h

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkMultiNodeSelectionWidget.cpp

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkMultiNodeSelectionWidget.h

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionButton.cpp

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionButton.h

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkSingleNodeSelectionWidget.cpp

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkSingleNodeSelectionWidget.h

View Options

Plugins/org.mitk.gui.qt.datastorageviewertest/src/internal/QmitkDataStorageViewerTestView.cpp

Reworkd AbstractNodeSelectionWidget and introduced node changed observersef9f6d0e4b97Actions

Description

Details

Event Timeline

Merged Changes

Changes (15)

rMITKef9f6d0e4b97

Modules/QtWidgets/files.cmake

Modules/QtWidgets/include/QmitkAbstractNodeSelectionWidget.h

Modules/QtWidgets/src/QmitkAbstractNodeSelectionWidget.cpp

Modules/QtWidgets/test/QmitkAbstractNodeSelectionWidgetTest.cpp

Modules/QtWidgets/test/files.cmake

Plugins/org.mitk.gui.qt.common/files.cmake

Plugins/org.mitk.gui.qt.common/src/QmitkAbstractNodeSelectionWidget.cpp

Plugins/org.mitk.gui.qt.common/src/QmitkAbstractNodeSelectionWidget.h

Plugins/org.mitk.gui.qt.common/src/QmitkMultiNodeSelectionWidget.cpp

Plugins/org.mitk.gui.qt.common/src/QmitkMultiNodeSelectionWidget.h

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionButton.cpp

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionButton.h

Plugins/org.mitk.gui.qt.common/src/QmitkSingleNodeSelectionWidget.cpp

Plugins/org.mitk.gui.qt.common/src/QmitkSingleNodeSelectionWidget.h

Plugins/org.mitk.gui.qt.datastorageviewertest/src/internal/QmitkDataStorageViewerTestView.cpp

Reworkd AbstractNodeSelectionWidget and introduced node changed observers
ef9f6d0e4b97
Actions