Diffusion Hyppopy (Observed Repository) ba147fa770ad

Add possibility to pass comm to MPI classes.
Concern Raisedba147fa770ad
Actions

Description

Add possibility to pass comm to MPI classes.

Signed-off-by: Andre Klein <andre.klein@dkfz-heidelberg.de>

Details

Auditors

floca

Provenance

• kleina

Authored on Jan 30 2020, 3:30 PM

Parents

rOBSHYPPOPY4dca75afb591: make sure to call loss_func_cand_preprocess and loss_func_postprocess correctly…

Branches

Unknown

Tags

Unknown

Event Timeline

• kleina committed rOBSHYPPOPYba147fa770ad: Add possibility to pass comm to MPI classes. (authored by • kleina).Jan 30 2020, 3:30 PM

@kleina Please check my comments and if nothing stands against it: 1) spawn a task to cover it. 2) cover it 😉 .

/mpiplayground.py
17–18	Why is this needed here? See comment below. I think it is unnecessary.
73–75	Why the need to explictly define MPI.COMM_WORLD in the script and passed to the MPI classes? Why not let MPISolverWrapper and MPIBlackboxFunction use by default MPI.COMM_WORLD if no mpi_comm is passed?

floca raised a concern with this commit.Feb 23 2021, 9:30 PM

This commit now has outstanding concerns.Feb 23 2021, 9:30 PM

I just saw that the default option is already implemented. Then I would just remove it in the playground or explain that both ways are possible. Because otherwise people might think that they always have to do it.

I agree. As we already said, we have to work on the mpiplayground anyways and convert it into a propper mpi_example. I will spawn a task for that and include your suggestion there.