Page MenuHomePhabricator

Crash if mitkDicomSeriesReader misses Tag [0020,0032] ImagePositionPatient
Closed, ResolvedPublic

Description

If you try to load a dicom Image without Tag[0020,0032] image position patient, MITK crashes.

Event Timeline

Added test case to branch. This test tries to load a DICOM file with missing PatientPosition (and also missing image data). Still this test should not crash.

I've fixed the bug by checking if the volume has valid images before trying to load it. I've commited it in branch bug-11130-crash-if-dicomTag-missing.

(In reply to comment #2)

I've fixed the bug by checking if the volume has valid images before trying
to load it. I've commited it in branch bug-11130-crash-if-dicomTag-missing.

Could you please also add a unittest for this fix? Image loading is quite a central feature of MITK so we should check that properly.

There is a unit test. I need the core modification to push it.

Thanks, now I checked the branch, couldn't read that from the wiki page.

[cefe0c]: Merge branch 'bug-11130-crash-if-dicomTag-missing'

Merged commits:

2012-03-07 14:59:27 Markus Fangerau [15d965]
Checking the case when no valid images are found within a series


2012-03-05 15:08:47 Michael Bauer [dc9abd]
Added test for defect DICOM image

This test should not crash

[1e9ab2]: Merge branch 'bug-11130-StringsFromInvalidChars'

Merged commits:

2012-03-22 10:01:16 Markus Fangerau [b062d7]
COMP: When getting inexisting tags from the scanner, it returns invalid char pointers. Trying to generate strings from these pointers wereissueing wrong assertions, causing the tests to fail under windows.

[f5d8ce]: Merge branch 'bug-11130-MITK-Data-Conflict'

Merged commits:

2012-03-23 17:05:32 Thiago dos Santos [708183]
MITK-Data file was wrongly merged.