Page MenuHomePhabricator
Create Task
Maniphest T13589

Build warnings in mitkStateMachine.cpp and mitkStateMachineFactory.cpp
Closed, ResolvedPublic
Actions

Description

When i compile MITK under 64bit Windows 7 using Visual Studio 10 I get a
lot of the following errors:

10>..\..\..\..\..\MITK_SOURCE\MITK-2012.09.0\Core\Code\Interactions\mitkStateMachine.cpp(294):
error C2220: warning treated as error - no 'object' file generated
10>
10>..\..\..\..\..\MITK_SOURCE\MITK-2012.09.0\Core\Code\Interactions\mitkStateMachine.cpp(294):
warning C4267: 'initializing' : conversion from 'size_t' to 'unsigned
int', possible loss of data
10>
10>..\..\..\..\..\MITK_SOURCE\MITK-2012.09.0\Core\Code\Interactions\mitkStateMachineFactory.cpp(123):
error C2220: warning treated as error - no 'object' file generated
10>
10>..\..\..\..\..\MITK_SOURCE\MITK-2012.09.0\Core\Code\Interactions\mitkStateMachineFactory.cpp(123):
warning C4267: 'argument' : conversion from 'size_t' to 'unsigned int',
possible loss of data

So I have to disable "treat warnings as error" to successfully compile
MITK.

Event Timeline

franza added projects: MITK, Bugzilla.Nov 12 2012, 11:15 AM
nolden added a subscriber: nolden.Nov 19 2012, 11:45 AM

@Christian: could you have a look at this on Wednesday? Maybe Stefan can help with Windows-specific issues.

• webechr added a subscriber: • webechr.Nov 21 2012, 3:20 PM

Problem caused by implicit conversions from size_t to unsigned int.
The warning could not be reproduced with default settings on Win7 64bit, 64bit MITK build.

franza added a subscriber: franza.Dec 5 2012, 2:05 PM

New remote branch pushed: bug-13589-FixBuildWarningsOfStateMachine

franza added a comment.Dec 7 2012, 3:38 PM

[8f6968]: Merge branch 'bug-13589-FixBuildWarningsOfStateMachine'

Merged commits:

2012-12-05 14:05:31 Alfred Franz [f5b2ed]
added explicit cast of vector::size() to unsigned int to avoid warnings

unfortunately there is no way to change the vtk methods which needs the unsigned int as parameter. But the size of the std::string must exceed 4.2 million characters to cause an error. This means about 400 MB text data, we think this won't happen.

2012-12-05 14:02:10 Alfred Franz [157485]
changed data type of local variable to size_t to make method safe

kislinsk edited projects, added MITK (2012-12); removed MITK.Aug 1 2016, 10:48 PM
MITK · MIC · IMSY · DKFZ