Page MenuHomePhabricator

Planar figure control points only movable when hovering over planar figure before
Closed, ResolvedPublic

Description

To be able to grab and move a control point of a planar figure, the mouse cursor must hover over the planar figure before entering the control point.

Regarding the bug summary this might be related to T15856.

Event Timeline

The description of this bug really sounds like the issue that should have been fixed with T15856.

On which branch did this issue occur? Are the changes of T15856 included in this branch?

I confirmed this bug with the current master, the release installer from last week and my branch which is based on a roughly 2-3 weeks old master.

I guess there are just some missing transitions in the planar figure state machine.

The fix in T15856 was something related the circle planar figure but I made changes in the interactor that were not enough to fix this problem also.

I will have a look at it later.

New remote branch pushed: bug-16077-planarfigure-controlpoints-only-movable-after-hovering

Hi guys, it´s now working fine for me. Please give it a try so we can merge it for the coming release.

Working fine for me too. We should definitely merge this bug as-is before the release as it is quite important for usability.

There is a small issue left: Move the mouse slowly from outside towards a control point. The control point is marked as hovered (green) one pixel before it is marked as selected (red). This should happen at the same time when crossing the outer pixels of a control point.

[857372]: Merge branch 'bug-16077-planarfigure-controlpoints-only-movable-after-

Merged commits:

2013-09-25 15:13:07 Sebastian Ordas [fc5b08]
fixed issue by reworking the planarfigure interaction statemachine