Page MenuHomePhabricator

Switch ScalarType from float to double
Closed, ResolvedPublic

Description

ScalarType shall be set to double. This implies a lot of tests failing due to too little accuracy. In this task:

  1. The build errors cf the switch to double accuracy shall be eliminated.
  2. Failing tests shall be reviewed and the cause for the error shall be eliminated.
  3. Tests which could not get to work shall be deactivated and a criticall bug which spawns from this bug shall be created.

Event Timeline

New remote branch pushed: bug-16340-switch_scalartype_from_float_to_double

[9e3cab]: Merge branch 'bug-16340-switch_scalartype_from_float_to_double'

Merged commits:

2013-10-30 17:41:54 Sebastian Wirkert [256f8c]
Merge branch 'bug-15852-u14-platformproject_scalartype_float_to_double' into bug-16340-switch_scalartype_from_float_to_double

Conflicts:
Core/Code/Testing/mitkTimeGeometryTest.cpp


2013-10-30 15:07:47 Sebastian Wirkert [e625f2]
Hash with to new MITKData. These ensure the DICOM tests run again.


2013-10-30 14:51:30 Sebastian Wirkert [cb48f2]
Updated test eps so the test passes. to be reviewed by M. Goetz.


2013-10-30 14:48:00 Sebastian Wirkert [b7de0f]
deactivated mitkNavigationDataRecorderTest (bug-16349), mitkNavigationDataTransformFilterTest (bug-16361),
mitkNavigationToolReaderAndWriterTest (bug-16350), mitkNavigationToolStorageSerializerAndDeserializerTest (bug-16351),
created bugs for all of this tests.


2013-10-30 14:20:01 Sebastian Wirkert [e25fac]
Disabled mitkGibbstTrackingTest because it could not be fixed in time. Created critical bug bug-16360 for M. Goetz


2013-10-29 12:51:35 Sebastian Wirkert [f2d00f]
Some more refined epses for mitkTimeGeometryTest.


2013-10-29 11:02:33 Sebastian Wirkert [a0066a]
Tried to fix TimeGeometry test, discuss with Michael G.


2013-10-25 16:09:24 Alexander Seitel [f45ed5]
Merge branch 'FixForKinectReconstructionTest' into bug-15852-u14-platformproject_scalartype_float_to_double


2013-10-25 16:06:41 Alexander Seitel [9fb734]
Calculate reference surface using basic functions available in ToFProcessingCommon. Compare resulting PointSets.


2013-10-23 16:38:32 Bastian Graser [95fab6]
Merge branch 'bug-15852-reorientplanes_not_working' into bug-15852-u14-platformproject_scalartype_float_to_double


2013-10-23 16:37:44 Bastian Graser [24c70c]
test for reorient slices commented out due to unclear desired behavior


2013-10-22 15:30:42 Sebastian Wirkert [fa29ec]
Merge branch 'bug-15852-u13-platformproject_scalartype_float_to_double' into bug-15852-u14-platformproject_scalartype_float_to_double


2013-10-21 15:21:18 Sebastian Wirkert [1b48d6]
Merge branch 'bug-15852-u12-platformproject_scalartype_float_to_double' into bug-15852-u13-platformproject_scalartype_float_to_double

Conflicts:
Core/Code/Testing/mitkSliceNavigationControllerTest.cpp
Modules/ContourModel/Rendering/mitkContourModelGLMapper2D.cpp


2013-10-17 17:06:13 Sebastian Wirkert [8d74f7]
more float to double replacements.


2013-10-17 16:00:13 Sebastian Wirkert [65fab4]
fixed a few double/float problems

Conflicts:

Modules/IGT/IGTFilters/mitkNavigationDataObjectVisualizationFilter.cpp


2013-10-15 11:01:14 Sebastian Wirkert [4b3255]

Added correct epsiolons in test.

2013-10-11 14:05:32 Sebastian Wirkert [bc5fbf]
Fixed test by setting epsilons to precision provided by testdata.


2013-10-11 14:04:57 Sebastian Wirkert [cf8777]
Merge branch 'bug-15852-u11-platformproject_scalartype_float_to_double' into bug-15852-u12-platformproject_scalartype_float_to_double

Conflicts:
Core/Code/Testing/mitkGeometry3DEqualTest.cpp
Modules/ContourModel/DataManagement/mitkContourModel.cpp
Modules/IGT/IGTFilters/mitkNavigationDataObjectVisualizationFilter.cpp


2013-10-11 12:46:31 Sebastian Wirkert [7891ca]
This file was incorrectly merged before.


2013-10-11 11:52:13 Sebastian Wirkert [497407]
Merge branch 'bug-15852-u3-tests_platformproject_scalartype_float_to_double' into bug-15852-u11-platformproject_scalartype_float_to_double

Conflicts:
Core/Code/Testing/mitkDICOMLocaleTest.cpp
Modules/ImageStatistics/Testing/mitkPointSetStatisticsCalculatorTest.cpp


2013-10-11 11:34:12 Sebastian Wirkert [b9b34d]
Set DICOMLocale epsilon to float eps.


2013-10-10 13:48:43 Sebastian Wirkert [4bfcc9]
The ground truth values in the test are much to unprecise for double

accuracy. Added epsilon to Equal methods to compensate for this.

2013-10-10 13:41:59 Sebastian Wirkert [d11de2]
Removed some debug variables from Slice NavigationControllerTest and set

pointSetStatisticsCalculatorTest to suited epsilons.

2013-10-09 16:08:20 Sebastian Wirkert [c08334]
commit stashed files


2013-10-02 17:46:15 Sebastian Wirkert [c541a1]
Fixed float occurences.

Conflicts:

Core/Code/Testing/mitkGeometry3DEqualTest.cpp
Modules/IGT/IGTFilters/mitkNavigationDataObjectVisualizationFilter.cpp


2013-10-02 13:36:20 Sebastian Wirkert [19fdec]
Some more float to ScalarType rewrites to make tests work.


2013-09-20 16:42:29 Sebastian Wirkert [c75b64]
Switched some hidden floats in Geometry to ScalarType.


2013-09-16 18:10:19 Sebastian Wirkert [cff684]
Introduced own epsilon for SlicedGeometry3DTests as discussed with
Michael Goetz. Set to float precision (1E-9).


2013-09-16 18:03:04 Sebastian Wirkert [8faf78]
Intruduced epsilon of 1E-9 for plane geometry tests as discussed with
Michael Goetz.


2013-08-28 17:54:44 Jan Hering [eb037b]
Merge branch 'bug-15852-GroupF-PointSetDifferenceCalculator' into bug-15852-u3-tests_platformproject_scalartype_float_to_double


2013-08-28 17:54:15 Jan Hering [90e5e6]
Reference values with double precision


2013-08-28 17:41:08 Sebastian Wirkert [29d8ed]
Reduced eps for CsvWriter to the number of digits actually wrote to the file.


2013-08-28 17:38:20 Jan Hering [59e524]
Merge branch 'bug-15852-GroupF-PointSetStatisticsCalculator' into bug-15852-u3-tests_platformproject_scalartype_float_to_double


2013-08-28 16:59:18 Jan Hering [8ba475]
Fixing reference values in test

  • now suitable for double-precision comparison, computed by external program

2013-08-28 16:57:28 Sebastian Wirkert [d7bb4e]
Fixed ToF module with Sven: no scalartype used in ToF, float instead for performance reasons.


2013-08-28 16:34:54 Thomas Van Bruggen [a4d99a]
Merge branch 'bug-15852-dicomLoad' into bug-15852-u3-tests_platformproject_scalartype_float_to_double


2013-08-28 16:34:19 Thomas Van Bruggen [291574]
replaced mitk::eps by 0.0001 to allow float imprecision


2013-08-28 15:34:34 Sebastian Wirkert [f1a4e4]
PointSet::SearchPoint input took float instead of ScalarType as a paramater.


2013-08-28 15:34:07 Sebastian Wirkert [e02704]
In TofDistanceImageToSurfaceFilter float* were used which created subtle errors since
they pointed to double values.


2013-08-28 14:35:40 Thomas Van Bruggen [750606]
Merge branch 'bug-15852-DicomLocaleTest' into bug-15852-u3-tests_platformproject_scalartype_float_to_double


2013-08-28 14:35:00 Sebastian Wirkert [99ea0a]
Fixed Test mitkPlanePositionManagerTest:
The class to which the results were compared was still outputting float, now switched to ScalarType.


2013-08-28 14:34:39 Thomas Van Bruggen [cff7ad]
chanced eps to 0.000001. This is the smallest number still within the precision of the dicom import


2013-08-28 14:27:59 Thomas Van Bruggen [a99b3b]
Merge branch 'bug-15852-DicomLocaleTest' into bug-15852-u3-tests_platformproject_scalartype_float_to_double


2013-08-28 14:27:12 Thomas Van Bruggen [910318]
fixed calls to mitk::Equal by adding a eps value of 0.01


2013-08-28 11:29:18 Sebastian Wirkert [7e14e3]
Merge branch 'bug-15852-tests_platformproject_scalartype_float_to_double' into bug-15852-u3-platformproject_scalartype_float_to_double


2013-08-28 09:09:50 Sebastian Wirkert [5ee1ce]
Fixed one error concerning ScalarType in itk class.


2013-08-26 17:22:16 Sebastian Wirkert [0c1895]
Merge branch 'bug-15852-platformproject_scalartype_float_to_double' into bug-15852-u3-platformproject_scalartype_float_to_double

Conflicts:
Core/Code/Testing/files.cmake
Modules/DiffusionImaging/FiberTracking/IODataStructures/FiberBundleX/mitkFiberBundleXReader.cpp


2013-08-20 11:15:41 Sebastian Wirkert [9d1a44]
PlanePositionManagerTest was not correctly ported to new test system, resulting in uncatched exceptions when the test failed. Fixed this.


2013-08-19 16:23:35 Sebastian Wirkert [132c36]
Merge commit 'a5caf1c4e80c50d7f6227130ba4c8ceb214f04c8' into bug-15852-platformproject_scalartype_float_to_double


2013-08-19 14:18:24 Sebastian Wirkert [b4f6ae]
Merge commit '1ca9ed4430640e46dc647f64a5294803bacbd55d' into bug-15852-platformproject_scalartype_float_to_double


2013-08-19 14:02:37 Sebastian Wirkert [a5caf1]
index on bug-15852-platformproject_enable_easy_conversion_of_datatypes: eb07436 Lots of probably uncritical float -> ScalarType changes.


2013-08-16 17:14:05 Sebastian Wirkert [eb0743]
Lots of probably uncritical float -> ScalarType changes.


2013-08-16 17:13:35 Sebastian Wirkert [eadb94]
Switched from itk::Point to mitk::Point in Contour. This might need a further look by a developer with more insight in the possible implications.


2013-08-16 15:20:59 Sebastian Wirkert [e7b92e]
Merge branch 'personal/wirkert/platformProject' into bug-15852-platformproject_enable_easy_conversion_of_datatypes


2013-08-13 17:44:25 Sebastian Wirkert [06e4ba]
Began refactoring of mitkVector:

Split it into one file containing common files: mitkDataTypeBasics and
mitkVector and mitkPoint for storing point and vector types. Of course this separation is not yet finished.


2013-08-13 16:12:18 Sebastian Wirkert [2b6a3d]
Added support for mitkPoint 2 POD conversion.
Started work on vtk 2 mitk conversions (which is really just a POD conversion).


2013-08-12 17:32:34 Sebastian Wirkert [0e63be]
Reverted one unnecessary change.


2013-08-12 16:49:06 Sebastian Wirkert [fb4284]
Experimentally created mitk::Point class to see which adaptions are necessary to get SW to compile again.


2013-07-30 13:47:21 Sebastian Wirkert [27b656]
New tests added for vnl conversion + restructuring.


2013-07-29 15:16:03 Sebastian Wirkert [038e1a]
Restructurings in test organisation


2013-07-29 11:25:45 Sebastian Wirkert [1ca9ed]
Scalartype from float to double and created some first tests for platformproject

New remote branch pushed: bug-16340-hash_in_mitk_data_set_to_right_value

[20197f]: Merge branch 'bug-16340-hash_in_mitk_data_set_to_right_value'

Merged commits:

2013-11-04 14:20:57 Sebastian Wirkert [4a152a]
COMP: correct value for mitk-data was lost during merge. Set correct again.

[801233]: COMP: Merge branch 'bug-16340-switch_scalartype_from_float_to_double'

Merged commits:

2013-11-04 16:49:29 Sebastian Wirkert [8d6be1]
COMP: Merge branch 'bug-16371-DICOM_tests_are_failing' into bug-16340-switch_scalartype_from_float_to_double


2013-11-04 16:47:02 Sebastian Wirkert [7644a9]
COMP: On Windows, stringstream does not return an error when parsing a NaN or INF
double value. Try to help this by also checking for std::isfinite.

[7fecbb]: COMP: Merge branch 'bug-16340-switch_scalartype_from_float_to_double'

Merged commits:

2013-11-04 17:18:56 Sebastian Wirkert [c5c4e8]
COMP: Merge branch 'bug-16371-DICOM_tests_are_failing' into bug-16340-switch_scalartype_from_float_to_double


2013-11-04 17:18:20 Sebastian Wirkert [946988]
Merge branch 'bug-16340-switch_scalartype_from_float_to_double' into bug-16371-DICOM_tests_are_failing


2013-11-04 17:17:34 Sebastian Wirkert [a783e1]
Previous method was not working in windows. Hopefully this one does.